balrog submitter doesn't set previous build number properly

RESOLVED FIXED

Status

Release Engineering
Release Automation
P2
major
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

3 years ago
balrog submitter sent Thundebird-32.0b1-build2 instead of Thundebird-32.0b1-build1, had to remove the blob and resubmit a new one


Executing: ['python', '/builds/slave/tb-rel-c-beta-l64_bld-00000000/tools/scripts/updates/balrog-submitter.py', '--build-properties', 'buildprops_balrog.json', '--api-root', 'https://aus4-admin.mozilla.org', '--username', 'tbirdbld', '-t', 'release', '--verbose', '--credentials-file', 'BuildSlaves.py']                                                   
Balrog request to https://aus4-admin.mozilla.org/releases/Thunderbird-33.0b1-build2                                                                                              
Data sent: None                                                                                                                                                                  
Starting new HTTPS connection (1): aus4-admin.mozilla.org                                                                                                                        
"HEAD /releases/Thunderbird-33.0b1-build2 HTTP/1.1" 200 0                                                                                                                        
Balrog request to https://aus4-admin.mozilla.org/releases/Thunderbird-33.0b1-build2/builds/Linux_x86_64-gcc3/en-US                                                               
Data sent: {'data_version': '60', 'product': u'Thunderbird', 'version': u'33.0', 'hashFunction': u'sha512', 'data': '{"platformVersion": "33.0", "partials": [{"hashValue": "e0ed82d45f18f930a3f34880d07837364a3635cf30fa8e67f83e66eb235318312a2982c24a80415ebd16a2cdaeff01704aae6d92046168232a7a7f74e8b9d5b4", "from": "Thunderbird-32.0b1-build2", "filesize": "15369372"}], "completes": [{"hashValue": "88e8fbfca7522d27697006d9fa0089cf97aacde2109674ece1aba6a3542017546cbff0e67748e53a801ecf387ec37e57118730f595c947b458ee607431f4033d", "from": "*", "filesize": "37069011"}], "buildID": "20140923230147", "displayVersion": "33.0 Beta 1", "appVersion": "33.0"}', 'schema_version': '3'}                                  
Starting new HTTPS connection (2): aus4-admin.mozilla.org                                                                                                                        
"PUT /releases/Thunderbird-33.0b1-build2/builds/Linux_x86_64-gcc3/en-US HTTP/1.1" 201 24
(Assignee)

Comment 1

3 years ago
Created attachment 8494663 [details] [diff] [review]
balrog-submitter-buildbotcustom.diff
(Assignee)

Comment 2

3 years ago
Created attachment 8494665 [details] [diff] [review]
balrog-submitter-tools.diff

to be tested
(Assignee)

Updated

3 years ago
Attachment #8494663 - Flags: review?(bhearsum)
(Assignee)

Updated

3 years ago
Attachment #8494665 - Flags: review?(bhearsum)
Comment on attachment 8494663 [details] [diff] [review]
balrog-submitter-buildbotcustom.diff

Review of attachment 8494663 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is simple enough that it doesn't need any testing...
Attachment #8494663 - Flags: review?(bhearsum) → review+
Attachment #8494665 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 4

3 years ago
Comment on attachment 8494663 [details] [diff] [review]
balrog-submitter-buildbotcustom.diff

I'm going to land the next patch once this one is in production.

https://hg.mozilla.org/build/buildbotcustom/rev/5b91afd38866
Attachment #8494663 - Flags: checked-in+
(Assignee)

Comment 5

3 years ago
Comment on attachment 8494665 [details] [diff] [review]
balrog-submitter-tools.diff

https://hg.mozilla.org/build/tools/rev/ecc4b383d9ce
Attachment #8494665 - Flags: checked-in+
(Assignee)

Comment 6

3 years ago
Worked!
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
l10n repacks are blowing up in 33.0b8:

Traceback (most recent call last):
  File "/builds/slave/rel-m-beta-lx_rpk_10-000000000/scripts/scripts/l10n/create-release-repacks.py", line 160, in createRepacks
    'partialInfo': partialInfo,
  File "/builds/slave/rel-m-beta-lx_rpk_10-000000000/scripts/lib/python/util/retry.py", line 33, in retry
    return action(*args, **kwargs)
  File "/builds/slave/rel-m-beta-lx_rpk_10-000000000/scripts/lib/python/balrog/submitter/cli.py", line 337, in run
    return ReleaseSubmitterBase.run(self, *args, schemaVersion=3, **kwargs)
  File "/builds/slave/rel-m-beta-lx_rpk_10-000000000/scripts/lib/python/balrog/submitter/cli.py", line 306, in run
    data.update(self._get_update_data(productName, version, build_number, **updateKwargs))
  File "/builds/slave/rel-m-beta-lx_rpk_10-000000000/scripts/lib/python/balrog/submitter/cli.py", line 360, in _get_update_data
    info["previousBuildNumber"] ,
KeyError: 'previousBuildNumber'

The previous patches only handled the en-US case.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 8497342 [details] [diff] [review]
[tools] Fix repacks by setting previousBuildNumber

I think this should fix up the problem, we do something similar earlier in the createRepacks().
Attachment #8497342 - Flags: review?(bhearsum)
Attachment #8497342 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 9

3 years ago
Oops, closed too early. :/
(Assignee)

Comment 10

3 years ago
This time looks better. Thanks for fixing.
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.