1072458 - Certain characters cannot be input using Bangla keyboard

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Maliha Momtaz Islam]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:31.0) Gecko/20100101 Firefox/31.0
Build ID: 20140715214335

Steps to reproduce:

Try to type "." by pressing the "." key in bn-Avro layout.


Actual results:

It produces a "।".


Expected results:

It should've produced a ".".

Comment 1

[Aniruddha Adhikary [:tuxboy]]

Thanks for the report Maliha! I have also noticed similar meaningless behavior with the "^" and ":" keys in bn-Avro.

Comment 2

[Maliha Momtaz Islam]

Attachment: Patch for bn-Avro character input

Comment 3

[Aniruddha Adhikary [:tuxboy]]

(In reply to Maliha Momtaz Islam from comment #2)
> Created attachment 8494721 [details] [review]
> Patch for bn-Avro character input

The patch looks good Maliha. Wonderful work!

Comment 4

[Aniruddha Adhikary [:tuxboy]]

Rudy can this patch be merged ASAP (before an update is rolled to Bangladeshi devices)?

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8494721 [details] [review]
Patch for bn-Avro character input

Hi  Maliha Momtaz Islam,

Thanks for the providing the patch.

1. Could you please help create a patch against the master branch, this is because we also need this fix in the master, and then we could uplift the patch to v1.4 branch.

2. Please help update the commit message as follows, (to include the bug number)
   Bug 1072458 - Certain characters cannot be input using Bangla keyboard.

--
Aniruddha Adhikary,

Thanks for the heads up, have you already tried out this patch?
If yes, please help give feedback+ on this patch.
Thank you.

Comment 6

[Jonathan Kew [:jfkthame]]

Does this patch still allow the "।" and "ঃ" characters to be typed when those are actually wanted?

It looks like the intent of the bn-Avro layout was that the "English" characters ".", ":" and "^" could be produced by following the initial keystroke with the "`" (backquote) key -- does that work?

Comment 7

[Aniruddha Adhikary [:tuxboy]]

Maliha, you need to switch the main layout's "." with "।" and add a key for "ঃ" in the symbol layout.

Comment 8

[Aniruddha Adhikary [:tuxboy]]

(In reply to Jonathan Kew (:jfkthame) from comment #6)
> Does this patch still allow the "।" and "ঃ" characters to be typed when
> those are actually wanted?

She updated the patch with input support for these characters.

(In reply to Jonathan Kew (:jfkthame) from comment #6)
> It looks like the intent of the bn-Avro layout was that the "English"
> characters ".", ":" and "^" could be produced by following the initial
> keystroke with the "`" (backquote) key -- does that work?

Well that is too much painful while typing on a phone!

Comment 9

[Aniruddha Adhikary [:tuxboy]]

Comment on attachment 8494721 [details] [review]
Patch for bn-Avro character input

Good to go!

Comment 10

[Maliha Momtaz Islam]

Attachment: patch for master branch

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8495320 [details] [review]
patch for master branch

May I know how a user type '&' with this change, or '&' is not necessary at all for Bangla?

Comment 12

[Aniruddha Adhikary [:tuxboy]]

& is actually not used in Bangla, we use "ও" or "এবং".

Comment 13

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8495320 [details] [review]
patch for master branch

r+ according to comment 12.

--
Thanks for working on this.

Comment 14

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/40dff263f02982b47fe548c403cd5b57d69b8d18

Comment 15

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8495320 [details] [review]
patch for master branch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): N/A
[User impact] if declined: The Bangla users may not be able to enter some common symbols with bn-Avro layout. And seems Bangladesh is one of our target shipping market of v1.4.
[Testing completed]: yes, manual test.
[Risk to taking this patch] (and alternatives if risky): should be low, simple keyboard layout changes.
[String changes made]: N/A

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Gaia v2.0 and v2.1 uplift as well, assuming it needs to land on those branches too.

Comment 17

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Ryan,

If this got approval-gaia-v1.4+, then we could uplift this patch to v2.0 and v2.1, right?
Do we need to ask for approvals 3 times for different branches?

Thanks.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Every branch needs its own approval, per the policy change announced a month ago and as reflected on the B2G Landing Page.
https://wiki.mozilla.org/Release_Management/B2G_Landing

Comment 19

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Yeah, thanks for double cofirming this. 
I was looking at that page, and originally, it has 
 >  1.4+ blocking bugs need an explicit approval to land on 2.0 
stated explicitly in this version, but now this statement is gone.
https://wiki.mozilla.org/index.php?title=Release_Management/B2G_Landing&oldid=1011332#v2.0.0

Comment 20

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8495320 [details] [review]
patch for master branch

Asking to land on v2.0 and v2.1 for the same reason as comment 15,
===
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): N/A
[User impact] if declined: The Bangla users may not be able to enter some common symbols with bn-Avro layout. And seems Bangladesh is one of our target shipping market of v1.4.
[Testing completed]: yes, manual test.
[Risk to taking this patch] (and alternatives if risky): should be low, simple keyboard layout changes.
[String changes made]: N/A

Comment 21

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/707c14abb8dc8046c9dcbeef25b59a331635c34f

Comment 22

[bhavana bajaj [:bajaj]]

:wayne, is there any value on landing this on 1.4 at this point ?

Comment 23

[Jan Jongboom [:janjongboom] (inactive)]

Bangladesh shipped already. We'd like it in 1.4, but will cherry pick it if it doesn't land.

Comment 24

[bhavana bajaj [:bajaj]]

(In reply to Jan Jongboom [:janjongboom] (Telenor) from comment #23)
> Bangladesh shipped already.
That's what I thought.
> We'd like it in 1.4, but will cherry pick it if
> it doesn't land.
How would the cherry-picking help ? Are you planning to release an update for this? Or is it more helpful to have other upcoming releases have this fix?

Comment 25

[Jan Jongboom [:janjongboom] (inactive)]

we'll send out an OTA update soon, yes

Comment 26

[Wayne Chang [:wchang]]

Jan thanks for answering.

Comment 27

[Ryan VanderMeulen [:RyanVM]]

This'll need rebasing for v1.4 and v2.0 uplift.

Comment 28

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

v1.4,
bb76c81f83e1e4acc2d2972a451db2bce78c8f34

2.0,
5616d86d52970bae0fdc65eaf7db97360172e750