1072529 - crash in java.lang.IllegalStateException: empty actions queue at org.mozilla.gecko.GeckoEditable$ActionQueue.poll(GeckoEditable.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-030ce5b2-6c44-4241-acca-d5d3d2140924.
=============================================================

java.lang.IllegalStateException: empty actions queue
	at org.mozilla.gecko.GeckoEditable$ActionQueue.poll(GeckoEditable.java:305)
	at org.mozilla.gecko.GeckoEditable.notifyIME(GeckoEditable.java:748)
	at org.mozilla.gecko.GeckoAppShell.notifyIME(GeckoAppShell.java:510)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:365)
	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:186)

I hit this twice when inputing text into the search activity search field

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #0)

> I hit this twice when inputing text into the search activity search field

Does GeckoEditable get used in the SearchActivity?

Comment 3

[Dave Royal]

bug 1131985 doesn't always cause this crash. I added some more info to. HTH.

Comment 4

[Dave Royal]

Attachment: Test QPython script that generates the same failure

I've established that this bug is triggered by the use of startActivityForResult in the calling app.

I have a python script that calls Firefox from within a QPython program. It uses startActivity(intent) and it works fine - calls the browser and returns to QPython when the back triangle is tapped.

I amended it to use startActivityForResult(intent,0) as SparseRSS does. Firefox then exhibits this bug.

(I don't know what 'result' the original program was or could be expecting.)

Comment 5

[Dave Royal]

I intended to post that to bug 1131985 - sorry

Comment 6

[Catalin Suciu [:csuciu]]

Attachment: crashlog.txt

I'm able to reproduce this crash constantly on Sony Xperia Z2 10" with Android 4.4.4:

STR's:
1. Visit any site that contains a search field (e.g. google.com)
2. Tap into the search field -> VKB opens
3. Connect the device to the magnetic charger

Result: Firefox crashes
https://crash-stats.mozilla.com/report/index/07745d33-5c9c-4bba-9a14-cc1b72150406

Comment 7

[Kevin Brosnan [Ex-Mozilla]]

That is kinda bazaar though str is cool. I think snorp was sent one of these tablets.

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

Jim, do you have a good idea of what's going on here?

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

I think I know what's going on.

Comment 10

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Only create GeckoEditable once (v1)

I think the crash is happening because, when we get a new LayerView, we create a new GeckoEditable. If nsWindow is still processing IME events from the old GeckoEditable, it will reply to these events through the new GeckoEditable, which doesn't know about these old events. One simple fix is to only use one instance of GeckoEditable, and rebind it to the new LayerView when we have one. I removed the corresponding lines in GeckoApp because I think that code is obsolete now.

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/fx-team/rev/2f51d61e4fef

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2f51d61e4fef

Comment 13

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: Crash with fix, would be great to take if jchen is ok with uplift.

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Jim, can we have an uplift request to aurora & beta? Thanks.
Tracking as it is a crash.

Comment 15

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8592270 [details] [diff] [review]
Only create GeckoEditable once (v1)

Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Occasional crash in all current versions
[Describe test coverage new/current, TreeHerder]: m-c
[Risks and why]: Small risk due to changing startup path but nightly looks okay.
[String/UUID change made/needed]: None

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ae4189b7a042

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/69e54b268783

Comment 18

[Catalin Suciu [:csuciu]]

Verified as fixed on latest Nightly and Aurora
Still needs to be verified on Beta 38.0b6