1072537 - clang plugin's needles_by_line() doesn't return correct format

Status: RESOLVED FIXED

(Webtools Graveyard :: DXR, defect)

Description

[Erik Rose [:erik][:erikrose]]

It returns something like this...

[[{'end': 5, 'start': 5, 'term': ('c-function', 'main')},
  {'end': 5, 'start': 5, 'term': ('c-function', 'main(int, char **)')},
  {'end': 14, 'start': 14, 'term': ('c-variable', 'argc')},
  {'end': 26, 'start': 26, 'term': ('c-variable', 'argv')},
  {'end': 14, 'start': 14, 'term': ('c-variable', 'main(int, char **)::argc')},
  {'end': 26, 'start': 26, 'term': ('c-variable', 'main(int, char **)::argv')},
  {'end': 14, 'start': 14, 'term': ('c-member', 'main(int, char **)')},
  {'end': 26, 'start': 26, 'term': ('c-member', 'main(int, char **)')},
  {'end': 5, 'start': 5, 'term': ('c-sig', '(int, char**) -> int')}]]

...when what we need is an iterable of key/value pairs.

Comment 1

[[github robot]]

Commit pushed to function-needle at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/2acac828d0f37b159d944668fbb13e898d7b34d2
Emit clang needles in the right format. Fix bug 1072537.

They were coming out as dicts. Now they are key/value pairs.

I may have screwed up annotations() by changing group_needles(), but I suspect it didn't work before anyway.

Comment 2

[[github robot]]

Commit pushed to es at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/2acac828d0f37b159d944668fbb13e898d7b34d2
Emit clang needles in the right format. Fix bug 1072537.

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/2acac828d0f37b159d944668fbb13e898d7b34d2
Emit clang needles in the right format. Fix bug 1072537.