1072616 - [Active Call Indicator] Update Animated Active Call Indicator

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Eric Pang [:epang] UX]

Attachment: [Spec] Ambient Indicator Active Call

Hi Alive, 

Can you help with making a few updates to the animation for active call?

Updates Include:

1. Change of colours
- The new colour values can be found in the spec

2. Motion
- We want to get something closer to the attached animation
- It's around 1 'pulse' per second.  Each pulse fades in and starts at 8.6 rem then fades to 0% towards the edges.  Before one pulse reaches the edge the next comes in
- You'll be able to get a better idea from the animation
- Please let me know if there's a better way to describe the timings to you

3. Banner is shown again
- If the user does not return to the call the banner should come down every 30secs to remind the user of the active call.  The Banner should be shown for 5 secs.

Please let me know if you have any questions!

Thanks,
Eric

Comment 1

[Eric Pang [:epang] UX]

Hi Alive, have you had a chance to work on this bug?

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Eric Pang [:epang] from comment #0)
> Created attachment 8494794 [details]
> [Spec] Ambient Indicator Active Call
> 
> Hi Alive, 
> 
> Can you help with making a few updates to the animation for active call?
> 
> Updates Include:
> 
> 1. Change of colours
> - The new colour values can be found in the spec
> 
> 2. Motion
> - We want to get something closer to the attached animation
> - It's around 1 'pulse' per second.  Each pulse fades in and starts at 8.6
> rem then fades to 0% towards the edges.  Before one pulse reaches the edge
> the next comes in
> - You'll be able to get a better idea from the animation
> - Please let me know if there's a better way to describe the timings to you
> 
> 3. Banner is shown again
> - If the user does not return to the call the banner should come down every
> 30secs to remind the user of the active call.  The Banner should be shown
> for 5 secs.
> 
> Please let me know if you have any questions!
> 
> Thanks,
> Eric

Sorry for late response.
Item 1, 2 is workable, but I need to confirm about item 3.

The behavior will affect every attention window, do you want to spam the user even while he is on a fullscreen app or fullscreen video?

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Eric Pang [:epang] from comment #0)
> 2. Motion
> - We want to get something closer to the attached animation
> - It's around 1 'pulse' per second.  Each pulse fades in and starts at 8.6
> rem then fades to 0% towards the edges.  Before one pulse reaches the edge
> the next comes in
> - You'll be able to get a better idea from the animation
> - Please let me know if there's a better way to describe the timings to you

This one seems no difference from the previous spec, is there?

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: patch for master, v2

Change the indicator height
Change the color of handle and background
Add the 45degree cut edge
Add the 30s respawn

Still not sure what's the problem of the animation because it's designed per spec.
Could you elaborate more what's different from what you think?

Comment 5

[Eric Pang [:epang] UX]

Comment on attachment 8497971 [details] [review]
patch for master, v2

Hey Alive, thanks for working on this!  It's looking good but I'm minusing based on the animation and a few things I've noticed.

For the motion I should have attached a motion for you to follow.  I'll attach one shortly.

A few issues I noticed:

1. After you return to the active call and hang up the animation still can be seen for a second, is there a way to stop the animation as soon as the user returns to the call?

2. I'm not sure if this is related to the active call, but sometimes while the active call indicator is shown the screen keeps going black and I can't get back to my call for a few tries.

Comment 6

[Eric Pang [:epang] UX]

Attachment: [motion] Ambient Indicator.mp4

Hey Alive, here's the motion.  The difference is that it has equal time spaces in between the pulses (around 1 pulse every second).  When one pulse is almost done the next starts.  The implementation currently feels like 2 pulses per second.  Let me know if you have any questions, thanks again!

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8497971 [details] [review]
patch for master, v2

* Fix callscreen terminated timing to make sure indicator doesn't spawn while closing.
* Fix the animating handle count to try to match the spec; need finetune by UX
* Add spawn timer and test

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Eric Pang [:epang] from comment #5)
> Comment on attachment 8497971 [details] [review]
> patch for master, v2
> 
> Hey Alive, thanks for working on this!  It's looking good but I'm minusing
> based on the animation and a few things I've noticed.
> 
> For the motion I should have attached a motion for you to follow.  I'll
> attach one shortly.
> 
> A few issues I noticed:
> 
> 1. After you return to the active call and hang up the animation still can
> be seen for a second, is there a way to stop the animation as soon as the
> user returns to the call?

fixed

> 
> 2. I'm not sure if this is related to the active call, but sometimes while
> the active call indicator is shown the screen keeps going black and I can't
> get back to my call for a few tries.

I am not seeing this in my side. If you repro it could you record it or give me STR to repro? Thanks.

Comment 9

[Eric Pang [:epang] UX]

Attachment: VID_20141001_1737182.mp4

Hi Alive, I've attached a video of the problem I'm seeing.

STR: 

1. Call phone and answer call
2. Press home key, wait for toast to go up
3. Try to pull down utility tray

Hope this help!

Comment 10

[Eric Pang [:epang] UX]

Hey Alive, I've also talked to Rob and he said we can increase the re spawn of the toast to 45 sec :)

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Eric Pang [:epang] from comment #9)
> Created attachment 8498301 [details]
> VID_20141001_1737182.mp4
> 
> Hi Alive, I've attached a video of the problem I'm seeing.
> 
> STR: 
> 
> 1. Call phone and answer call
> 2. Press home key, wait for toast to go up
> 3. Try to pull down utility tray
> 
> Hope this help!

Eric, this is expected! It's called proximity sensor; the phone thinks you are nearing the phone by the ear so it turns off screen. I don't think it's caused by my patch. Could you confirm the current behavior on your phone?

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: patch for master

Recreate the pr due to gaia tree issue.

Comment 13

[Etienne Segonzac (:etienne)]

Comment on attachment 8498730 [details] [review]
patch for master

nice!

Comment 14

[Eric Pang [:epang] UX]

Comment on attachment 8498730 [details] [review]
patch for master

This looks great Alive!  Thanks for working on this :). 

One small issue though when the user wants to return to their call.  After you open the tray and press the "Callscreen Tap to show" the tray seems to sometimes close faster then the text and highlight.  This causes the highlight and text to be seen without the tray for a fraction of a sec, is this something that can be fixed?  It is similar to the ambient indicator staying on the screen a little to long (which you already fixed).

I'll give an R+ cause I don't want our time difference to slow this down for landing, but if you can look at the small issue that would be great!

Thanks again, great work!

Comment 15

[(inactive after 6/18) Alive Kuo [:alive]]

I am waiting for gij re-run before merging this.

Comment 16

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/48ce866cd048a7a8ec9d07df8827cce691bc194d

Comment 17

[Eric Pang [:epang] UX]

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #16)
> https://github.com/mozilla-b2g/gaia/commit/
> 48ce866cd048a7a8ec9d07df8827cce691bc194d

Hi Alive, can you flag this approval-gaia-v2.1?

It's a change that UX really wants so we're hoping to have it uplifted. Thanks!

Comment 18

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8498730 [details] [review]
patch for master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): visual polish after bug 927862
[User impact] if declined: inconsistent user experience with notification indicator
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): riskless
[String changes made]: no

Comment 19

[[:fabrice] Fabrice Desré]

Comment on attachment 8498730 [details] [review]
patch for master

not bad enough

Comment 20

[Alberto Pastor [:albertopq]]

Comment on attachment 8498730 [details] [review]
patch for master

Can we reconsider approving this? It fixes a performance issue described in Bug 1072616.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): visual polish after bug 927862
[User impact] if declined: inconsistent user experience with notification indicator. Also causes b2g main thread 10%-20% usage when shown.
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): riskless
[String changes made]: no

Comment 21

[Alberto Pastor [:albertopq]]

(In reply to Alberto Pastor [:albertopq] from comment #20)
> Comment on attachment 8498730 [details] [review]
> patch for master
> 
> Can we reconsider approving this? It fixes a performance issue described in
> Bug 1072616.

Err, I meant Bug 1104151. Thanks!

Comment 22

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/56cf1b433d01fa6e826e2f50c954e5c7fc0f5730