1072723 - [NFC] Could not import contact via NFC

Status: VERIFIED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Alison Shiue]

Attachment: import_contact_issue.log

Full flash KK build
Gaia-Rev        03d7bcad57ea281869976a9aed0a38849f7c8bc5
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/1735ff2bb23e
Build-ID        20140924160204
Version         35.0a1

* 2.1 does not have this issue.

STR:
1. Device enable NFC
2. Device tap on a NFC tag which contains a vcard

Expect result:
Import the contact successfully

Actual result:
Could not import the contact (http://youtu.be/0oKCzeUGO1k)

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb. 9]

line 613: W/Communications( 1440): [JavaScript Error: "ReferenceError: VCFReader is not defined, did you mean 'reader'?" {file: "app://communications.gaiamobile.org/shared/js/contacts/import/utilities/import_from_vcard.js" line: 52}]

Hi Francisco,
Can you take a look at this?
Gracias~~

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Ei!

Thanks for letting us know, we probably have introduced this error when landing bug 1071722, we will need to add more dependencies when handling the import activity.

Will take care of it.

Gracias Yoshi!

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 24472

Yoshi can you try the patch, unfortunately don't have a nfc tag with me right now.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb. 9]

Comment on attachment 8495930 [details] [review]
Pointer to PR 24472

yeah, the patch works.

Thank you, Francisco.

Comment 5

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Thanks Francisco! r+

Merged at 5e76017d6e47ac9d47ded040304c015b9381cb15

Comment 6

[Alison Shiue]

Verified on
Gaia-Rev        77ef35f5429bc3dfe9ca192b9aacc3c0bf8857de
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/7c24470b6b3a
Build-ID        20140929160203
Version         35.0a1

Comment 7

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

removing nomination as it was verified on master (2.2)