Closed
Bug 1072723
Opened 10 years ago
Closed 10 years ago
[NFC] Could not import contact via NFC
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(blocking-b2g:-, b2g-v2.1 unaffected, b2g-v2.2 verified)
VERIFIED
FIXED
blocking-b2g | - |
Tracking | Status | |
---|---|---|
b2g-v2.1 | --- | unaffected |
b2g-v2.2 | --- | verified |
People
(Reporter: ashiue, Assigned: arcturus)
References
Details
(Keywords: regression)
Attachments
(2 files)
Full flash KK build Gaia-Rev 03d7bcad57ea281869976a9aed0a38849f7c8bc5 Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/1735ff2bb23e Build-ID 20140924160204 Version 35.0a1 * 2.1 does not have this issue. STR: 1. Device enable NFC 2. Device tap on a NFC tag which contains a vcard Expect result: Import the contact successfully Actual result: Could not import the contact (http://youtu.be/0oKCzeUGO1k)
Reporter | ||
Updated•10 years ago
|
blocking-b2g: --- → 2.2?
QA Whiteboard: [COM=NFC]
Reporter | ||
Updated•10 years ago
|
Keywords: regression
Reporter | ||
Updated•10 years ago
|
status-b2g-v2.1:
--- → unaffected
status-b2g-v2.2:
--- → affected
line 613: W/Communications( 1440): [JavaScript Error: "ReferenceError: VCFReader is not defined, did you mean 'reader'?" {file: "app://communications.gaiamobile.org/shared/js/contacts/import/utilities/import_from_vcard.js" line: 52}] Hi Francisco, Can you take a look at this? Gracias~~
Flags: needinfo?(francisco)
Assignee | ||
Comment 2•10 years ago
|
||
Ei! Thanks for letting us know, we probably have introduced this error when landing bug 1071722, we will need to add more dependencies when handling the import activity. Will take care of it. Gracias Yoshi!
Assignee: nobody → francisco
Flags: needinfo?(francisco)
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•10 years ago
|
||
Yoshi can you try the patch, unfortunately don't have a nfc tag with me right now.
Attachment #8495930 -
Flags: feedback?(allstars.chh)
Assignee | ||
Updated•10 years ago
|
Attachment #8495930 -
Flags: review?(sergi.mansilla)
Comment on attachment 8495930 [details] [review] Pointer to PR 24472 yeah, the patch works. Thank you, Francisco.
Attachment #8495930 -
Flags: feedback?(allstars.chh) → feedback+
Blocks: NFC-Gaia
Comment 5•10 years ago
|
||
Thanks Francisco! r+ Merged at 5e76017d6e47ac9d47ded040304c015b9381cb15
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 6•10 years ago
|
||
Verified on Gaia-Rev 77ef35f5429bc3dfe9ca192b9aacc3c0bf8857de Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/7c24470b6b3a Build-ID 20140929160203 Version 35.0a1
Status: RESOLVED → VERIFIED
Reporter | ||
Updated•10 years ago
|
Updated•10 years ago
|
Attachment #8495930 -
Flags: review?(sergi.mansilla) → review+
Comment 7•10 years ago
|
||
removing nomination as it was verified on master (2.2)
blocking-b2g: 2.2? → -
You need to log in
before you can comment on or make changes to this bug.
Description
•