Closed Bug 1072834 Opened 6 years ago Closed 6 years ago

[Settings] Remove simple tiling from the developer panel

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: arthurcc, Assigned: fjaguero, Mentored)

References

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
arthurcc
: review+
Details | Review
Simple tiling has been removed in bug 1071825 and we should also remove the option from the developer menu.
Hi! I think I can take this one but I will need a bit of mentorship since is the first one.
Cool, let me know if you need any help.
Assignee: nobody → fjaguero
Ok, working on in this weekend.
Hi Arthur, I tried to follow the guides to build Gaia and start working on the issue but I couldn't find the right steps. Some commands use the directory gaia/ but I don't have that directory in my cloned repo. Can you link me to the correct start instructions?

Thanks.
I made to have it working. Submitting the patch.
Attached file Added PR code
Attachment #8496594 - Flags: review?(arthur.chen)
Comment on attachment 8496594 [details] [review]
Added PR code

Good job! r=me. I'll land the patch once it passes all tests on TBPL. Thanks!
Attachment #8496594 - Flags: review?(arthur.chen) → review+
Ok, great! Thanks for the help.
master: 032c9d0523945764d6904f7574b2499e1126b7a6
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.