1072868 - [B2G][Telephony] introduce a new interface as proxy between telephony modules and AudioManager

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

We want to greatly reduce the need to change the telephony-related interfaces as we make other changes to gecko. It would be good if we separate the interfaces that we use towards Telephony modules from those that we use in the rest of gecko.

This bug is for discussing how we could deal with AudioManager queried in Telephony modules.

A possible proposal:

nterface nsITelephonyAudioService : nsISupports    
{    
  /**    
   * Microphone muted?    
   */    
  attribute boolean microphoneMuted;    
    
  /**    
   * Set the phone's audio mode.    
   */    
  const long PHONE_STATE_INVALID          = -2;    
  const long PHONE_STATE_CURRENT          = -1;    
  const long PHONE_STATE_NORMAL           = 0;    
  const long PHONE_STATE_RINGTONE         = 1;    
  const long PHONE_STATE_IN_CALL          = 2;    
  const long PHONE_STATE_IN_COMMUNICATION = 3;    
    
  attribute long phoneState;    
    
  /**    
   * Configure a particular device ("force") to be used for communication.
   */    
  const long FORCE_NONE            = 0; // the default    
  const long FORCE_SPEAKER         = 1;    
    
  void setForceForUseCommunication(in long force);    
  long getForceForUseCommunication();       
};                

Comments are welcome ~

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Aknow,

Would you mind taking care of this? I also think we might need to take bug 1072808 into account when proposing a solution to this. Thank you.

Comment 2

[Szu-Yu Chen [:aknow] (inactive)]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #1)
> Hi Aknow,
> 
> Would you mind taking care of this? I also think we might need to take bug
> 1072808 into account when proposing a solution to this. Thank you.

Sure. Btw, what's the target milestone for this bug.

Comment 3

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 1: Add nsITelephonyAudioService (interface)

Comment 4

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 2: Add TelephonyAudioService (implementation)

Comment 5

[Szu-Yu Chen [:aknow] (inactive)]

try looks good
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=3f7a6428c952

Comment 6

[Szu-Yu Chen [:aknow] (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/f8611fe1576a
https://hg.mozilla.org/integration/b2g-inbound/rev/b13aee1c3fa2

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f8611fe1576a
https://hg.mozilla.org/mozilla-central/rev/b13aee1c3fa2