1072920 - A search with a single result should take me right to the source

Status: RESOLVED FIXED

(Webtools Graveyard :: DXR, defect)

Description

[(not currently active) Ted Mielczarek]

This would be especially useful for path: searches, like:
http://dxr.mozilla.org/mozilla-central/search?tree=mozilla-central&q=path:runxpcshelltests&redirect=true

There's only a single result there, it should just take me right to the file.

Comment 1

[Erik Rose [:erik][:erikrose]]

Definitely. I'm about to rewrite the "direct search" functionality for the upcoming Elasticsearch port of DXR. I'll make sure this gets in.

In the meantime, did you know there's a filename+line_num shortcut? If you type "runxpcshelltests.py:1" and hit Return, you'll be plopped directly at the file, at that line.

Comment 2

[(not currently active) Ted Mielczarek]

I didn't know that, but I have lazy habits built up from mxr where I would use a keyword search to search for part of a filename. I've replaced that with a keyword search that searches dxr for path:%s, which is working pretty well, but this would be a little nicer. :)

Comment 3

[Erik Rose [:erik][:erikrose]]

Soon (Q4?) you will indeed be able to just type some crap into the field and have filenames containing said crap pop up. :-)

Keep the observations coming. I've been closeted away porting DXR to ES the last couple of months, but I'm about to land that and then do a bunch of feature work that ES makes possible, including some major UI improvements like result mixing (https://wiki.mozilla.org/DXR_Query_Language_Refresh) and query language fixing (https://wiki.mozilla.org/DXR_Query_Language_Refresh). Seriously, don't hesitate to scribble on any of the DXR wiki pages. The roadmap is particular easy to work stuff into: https://wiki.mozilla.org/DXR_Roadmap. Thanks again!

Comment 5

[Peter Elmers [:new_one]]

https://github.com/mozilla/dxr/pull/556 will fix this very soon.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/19ce5f7ecaa02de736324057e168c4633afed9df
Merge branch 'single_result-2'.

Fix bug 1072920.