1072947 - 2-14% all platform tp5+ regressions on inbound (v.35) Sept 23 from push 408238add852

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

here is a summary of the regressions:
http://54.215.155.53:8080/alerts.html?rev=408238add852&table=1&show_improvement=1

and a list with links to graphs:
http://54.215.155.53:8080/alerts.html?rev=408238add852

in addition to tp5 regressions, session restore took a hit.

For more information on the tests:
https://wiki.mozilla.org/Buildbot/Talos/Tests

and information on how to run the tests:
https://wiki.mozilla.org/Buildbot/Talos/Running

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

as patch authors, please take a few minutes to look at this and speculate whether your patch contributes to this across the board regressions.

Comment 2

[Andrea Marchesini [:baku]]

(In reply to Joel Maher (:jmaher) from comment #1)
> as patch authors, please take a few minutes to look at this and speculate
> whether your patch contributes to this across the board regressions.

I don't think it's my patch because it's about navigator.userAgent attribute: all the logic runs when the page asks for this particular attribute in workers.

Do we have a way to test which patch is causing this regression?

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Bug 947044 is the obvious candidate.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

we could backout the patch(es) one by one on try and compare the results.  90% of the time that works quite well.

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

This is likely bug 947044. I'm getting it backed out now.

Comment 6

[Blake Wu [:bwu][:blakewu]]

My patch is only for video seek and should not cause this regression.

Comment 7

[Rik Cabanier]

I would be surprised if my patched caused an across the board regression. How can I see what patch is in this push?

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Hi Rik, it is this patch: http://hg.mozilla.org/integration/mozilla-inbound/rev/d3f47846850e, but from the sounds of it, it is most likely Nick's patch.

Nick, have you tested backing out your patch or ammending it on try?

Comment 9

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Joel Maher (:jmaher) from comment #8)
> Hi Rik, it is this patch:
> http://hg.mozilla.org/integration/mozilla-inbound/rev/d3f47846850e, but from
> the sounds of it, it is most likely Nick's patch.
> 
> Nick, have you tested backing out your patch or ammending it on try?

Yeah, its been backed out, if the regressions haven't gone away, then I guess it wasn't caused by that patch.

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

all regressions are fixed.  Shall we close this bug?

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

Nick, do you have plans to reland or do any further work on this bug?  I would like to close it if possible.