1072954 - Issues with hidden/unhidden devices on Synced Tabs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Device: Nexus 5 (Android 4.4)
Builds: Firefox for Android 35.0a1 (2014-09-24)

Steps to reproduce:
1. Open Firefox and set up sync
2. Go to the synced tabs panel and hide all device
3. Unhide a device from the list

Expected results:
- Nothing happens. The device remains hidden

Actual results:
- The device selected should reappear in the list

Please see the following video:https://www.youtube.com/watch?v=rXMhmTzcfYw&feature=youtu.be

Some scenarios: 

- So I have 9 devices: 
device 1. teodoravermesan's Nightly on P5086: last synced: 12 min ago
device 2. nightly on nexus 4; last synced: 8h ago
device 3. firefox on grand in: last synced: 23h ago
device 4. firefox beta on A500: last synced: 2d ago
device 5. aurora on nexus 7: last synced: 3d ago
device 6. nightly on nexus 7: last synced: 3d ago
device 7. nightly on alcatel: last synced: 6d ago
device 8. nightly on alcatel: last synced: 7d ago
device 9. teo's firefox on teo-pc: last synced: 7d ago

1. I hide all 9 devices: From the list I try to choose one device to unhide: only teodoravermesan's Nightly on P5086 appears: (it is the recent device synced: 12min ago). Now I have 8 devices hidden, 1 shown: from the list, If I choose another device: for example Firefox on grand in (synced 23h ago) or  Aurora on Nexus 7(synced 3d ago) to appear in the list, nothing happens. Only if I choose Nexus 4, it will appear, because it is the recent device synced (synced 8h ago) and so on...

2. If I have all devices hidden and choose the first 3 or the first 5 listed, or all of them, they will appear.

3. If I have 9 hidden devices and choose 
device5 & device9 to show, nothing happens. 
device2 & device4 only device2 appears.
device4&device&5&device6 to show, nothing happens
etc

Comment 1

[Nick Alexander :nalexander [he/him]]

TeoVermesan: thanks for great STR.  This is indeed a problem, but luckily I think it's just a problem with the dialog code that reports back the set of devices to unhide.  I've gotten this wrong myself before and thought I worked around it, but apparently not.

Comment 2

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/635a5cfa6baa

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/635a5cfa6baa

Comment 4

[Aaron Train [:aaronmt]]

Teo, can you verify this one?

Comment 5

[Teodora Vermesan (:TeoVermesan)]

Currently on my "Synced Tabs" panel I have 5 devices and perform the following steps:
- Hide all and choose one device random to unhide: then hide it and try to unhide the remaining 4
- Hide all and select all 5 devices to unhide.
- Hide all and then choose any combination of 2 devices to show
- Hide all and then choose any combination of 3 devices to show
- Hide all and then choose any combination of 4 devices to show

Works ok and the devices appear.
so verified fixed on Samsung S5 (Android 4.4) on latest Nightly (01-10-2014)

Comment 6

[Nick Alexander :nalexander [he/him]]

> so verified fixed on Samsung S5 (Android 4.4) on latest Nightly (01-10-2014)

Thanks for the quick QA turn-around.