1072997 - crash in java.lang.IllegalArgumentException: Unknown URL content://downloads/my_downloads at android.content.ContentResolver.insert(ContentResolver.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-6ea6a1bf-f296-40d5-ad73-485ca2140924.
=============================================================

java.lang.IllegalArgumentException: Unknown URL content://downloads/my_downloads
	at android.content.ContentResolver.insert(ContentResolver.java:862)
	at android.app.DownloadManager.addCompletedDownload(DownloadManager.java:1646)
	at org.mozilla.gecko.GeckoAppShell.scanMedia(GeckoAppShell.java:1812)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:365)
	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:186)

Comment 1

[Robert Kaiser]

[Tracking Requested - why for this release]:
This is a new startup crash in 35, with 2.5% of all crashes in 35.0b6.

For more details and reports, see https://crash-stats.mozilla.com/report/list?signature=java.lang.IllegalArgumentException%3A%20Unknown%20URL%20content%3A%2F%2Fdownloads%2Fmy_downloads%20at%20android.content.ContentResolver.insert%28ContentResolver.java%29

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

This is happening on devices where people have "disabled" the Download Manager [1][2]. You can do this by going into Settings > Apps > All Apps, and picking "Download Manager" then tapping "Disable". Android gives you a warning about doing this to a built-in app.

I can reproduce the crash when disabling the Download Manager, which is the backend provider, not the UI, which can be called Downloads in the Settings.

[1] http://stackoverflow.com/questions/10852821/downloadmanager-sends-status-successful-for-failed-download
[2] http://stackoverflow.com/questions/18979160/android-download-manager-issue-in-samsung-tab-gt-p3100

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: sysdm-disabled v0.1

This patch pulls the System DM checks into a helper function. The function also tests for a disabled DM. I am checking the backend provider, not the Downloads UI. I am also testing for IllegalArgumentException in case the applet is not even installed.

There are several COMPONENT_ENABLED_STATE_DISABLED* flags, so I test for ENABLED and DEFAULT.

Testing shows the patch works for adding and removing downloads without crashing.

For more info: http://developer.android.com/reference/android/content/pm/PackageManager.html#getApplicationEnabledSetting%28java.lang.String%29

Comment 4

[:Margaret Leibovic]

Comment on attachment 8542274 [details] [diff] [review]
sysdm-disabled v0.1

Review of attachment 8542274 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable.

::: mobile/android/base/DownloadsIntegration.java
@@ +90,5 @@
>              removeDownload(d);
>          }
>      }
>  
> +    public static boolean useSystemDownloadManager() {

This can be private.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Made the method private:

https://hg.mozilla.org/integration/fx-team/rev/09c3bfc70592

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8542274 [details] [diff] [review]
sysdm-disabled v0.1

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: #2 crash on Fx35 beta
[Describe test coverage new/current, TBPL]: Just landed, but we need to get this on Fx35 ASAP after a short bake time. 
[Risks and why]: Low risk. Minor code changes supported by all Android API levels.
[String/UUID change made/needed]: None

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/09c3bfc70592

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9b2625c9dc23

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8542274 [details] [diff] [review]
sysdm-disabled v0.1

Alright - let's get this into the final mobile beta asap.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bb209fcdbcdc

Comment 11

[Flaviu Cos]

The crash is no longer reproducible, but after re-enabling the download manager Firefox becomes unresponsive.

Comment 12

[Flaviu Cos]

Verified as fixed in builds:
- 35 beta 10;
- 36.0a2 (2015-01-06);
- 37.0a1 (2015-01-06).
Device: Asus Transformer Tab (Android 4.2.1).

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Flaviu Cos, QA [:flaviu] from comment #11)
> The crash is no longer reproducible, but after re-enabling the download
> manager Firefox becomes unresponsive.

We found that clearing data or rebooting the phone fixed the responsiveness. Given the unsupported nature of disabling system services, rebooting the device is a fine workaround.

Comment 14

[KOLANICH]

Could you just catch and kgnore this exception?