1073036 - Track program state more carefully to avoid setting unnecessarily

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

The overall idea is to basically create pipeline objects that we can switch between and only set the different state. The first part of this is to do this with shaders as glUseProgram looks to be the biggest state change area in profiles on OS X.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Redo workaround to avoid using Activate()

Activate is going away and we can trigger the workaround more explicitly using raw opengl.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Track the current program on the compositor

This makes it so that we track the current program in use by compositor and only switch it if it is different.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

This needs to be updated to clear the state when drawing from widget/android

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Attachment: This should fix up the android problem by adding a 'ResetProgram' function

This should fix up the android problem by adding a 'ResetProgram' function that's called when we get the gl context for raw use.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Attachment: Also use reset in GLBlitTextureImage

This should be the final version of this.

Comment 6

[Nicolas Silva [:nical]]

Comment on attachment 8524116 [details] [diff] [review]
Also use reset in GLBlitTextureImage

Review of attachment 8524116 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/opengl/OGLShaderProgram.cpp
@@ +549,3 @@
>      }
>    }
> +  MOZ_ASSERT(HasInitialized(), "Attempting to activate a program that's not in use!");

The message for this assertion makes much less sense now.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5140b218e6cc
https://hg.mozilla.org/mozilla-central/rev/f61b87621f13