1073060 - Confusing message when selecting a contact without telephone number nor e-mail to start a Loop call

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Maria Angeles Oteo (:oteo)]

When triaging the bug 1051690, we detected that when selecting a contact without phone number nor e-mail, the message shown could be confusing for the user. That's the reason to create a specific bug for that.

STR
1. Create a contact without any phone number nor email
2. Open Loop app
3. From Loop app click on contact and select the contact created in step 1

ACTUAL RESULT
The warning message is "The pick activity result is invalid".

EXPECTED RESULT
A more clear message for the user would improve the User experience.

Comment 1

[Maria Angeles Oteo (:oteo)]

Pau, can you help us with the message?
Thanks a lot!

Comment 2

[Pau Masiá [:Pau]]

Attachment: 2014-09-26-12-04-52.png

I would suggest to show a message like what is shown in SMS App. See attachment.

Hope it can help :)

Comment 3

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Pau's message suggest you need both the email address and the phone number, to make the call.
My native language is not english :) but I think this would be a bit better:
"This contact does not have either a phone number or an email adress"
WDYT?

Comment 4

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

The current message is quite generic: "The pick activity result is invalid", that makes me thing:
Borja, this message is only used in that scenario? or you could trigger this screen in other cases, like communication failure...

Comment 5

[Borja Salguero [:borjasalguero]]

Just in the case where the contact selected has no valid identity to be called.

Comment 6

[Pau Masiá [:Pau]]

I'm agree with Arnau. The message he proposes sounds better than the one currently implemented in the system. Thanks :)

Comment 7

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 8

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: 630c6f85db946ffce64dfad37092e7bc70ed8d8e

Comment 9

[mbarone]

There is an error in the message. See attachment. Adress instead of Address

Comment 10

[mbarone]

Attachment: 2014-10-06-09-14-43.png

Comment 11

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: follow up patch in github

Comment 12

[Borja Salguero [:borjasalguero]]

Comment on attachment 8500341 [details] [review]
follow up patch in github

Rebase & merge please! Thanks ;)

Comment 13

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged Follow up: 576dbf0eca348df58139a62e3f7917b18cecd9e4

Comment 14

[Javier de Prado]

Verified on flame, Gecko-7107b06.Gaia-c1f6089, lopp version: dbe5bf3, Ram: 512M, and spanish and english languages.