1073210 - Remove dangerous public destructor of MiscContainer

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8]]

This class is defined in content/base/src/nsAttrValueInlines.h.  Removing the public destructor could be tricky because sometimes this struct is refcounted and sometimes it isn't.

Comment 1

[Anuj Agarwal [:anujagarwal464]]

Attachment: bug1073210.diff

Comment 2

[Andrew McCreight [:mccr8]]

Comment on attachment 8496008 [details] [diff] [review]
bug1073210.diff

Review of attachment 8496008 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsAttrValue.cpp
@@ -282,2 @@
>    if (otherCont->IsRefCounted()) {
> -    delete ClearMiscContainer();

I don't think this is going to work.  If you look at ClearMiscContainer(), it does a bunch of stuff.  This whole MiscContainer thing is very odd and may require some serious reworking.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

The background for the odd looking code is bug Bug 760331.

Comment 4

[(no longer active)]

MiscContainer is no longer refcounted.