1073307 - Date.prototype.toLocaleTimeString doesn't support IANA timezone names

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, defect)

Description

[nicoo]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.6 Safari/537.36

Steps to reproduce:

Call `Date().toLocaleTimeString('fr', { timeZone: 'Europe/Paris' })` in JavaScript.


Actual results:

The timezone that was used is GMT.


Expected results:

The time should be converted to the specified timezone.

Comment 1

[nicoo]

This was sent from Chromium since I'm currently rebuilding Firefox ;)

While the spec (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleTimeString) states handling IANA timezone names isn't mandatory, it is extremely convenient and JavaScript applications might rely on it.
The rationale is similar to https://bugzilla.mozilla.org/show_bug.cgi?id=837961

Comment 2

[Jeff Walden [:Waldo]]

Yeah, it's something we should do.  Not certain when, but it'll happen eventually.

(I kinda feel like this is a dup, but if André didn't tag it so I'm not going to pretend second-guess him.  :-) )

Comment 3

[André Bargull [:anba]]

Attachment: intl-tolocale-tz.patch

No additional code changes, except for the ones in bug 837961, are required to support the timeZone property for Date.prototype.toLocale{Date,Time}String(). We only need to test everything works as expected.

Comment 4

[André Bargull [:anba]]

Attachment: Bug1073307.patch

Updated patch to include comments requested for similar tests in bug 837961. Carrying r+ from Waldo.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/551718400ad4
Add tests for timeZone support in Date.prototype.toLocaleString. r=Waldo

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/551718400ad4

Comment 7

[Florian Scholz (Open Web Docs)]

See bug 837961 comment 70 for doc updates.