1073328 - Only use actual system uncaught handler

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Right now we get the system uncaught handler in GeckoApp.onCreate through GeckoAppShell.registerGlobalExceptionHandler, but if GeckoApp.onCreate is called multiple times, we end up grabbing our own handler as the system handler.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Prevent using our own handler as system handler (v1)

I've only seen this in developer builds, but we should fix it by grabbing the system handler only once.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8495649 [details] [diff] [review]
Prevent using our own handler as system handler (v1)

Review of attachment 8495649 [details] [diff] [review]:
-----------------------------------------------------------------

oops :)

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4793e12b9720

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8495649 [details] [diff] [review]
Prevent using our own handler as system handler (v1)

Approval Request Comment

[Feature/regressing bug #]: bug 1066175

[User impact if declined]: Hang in rare situations when Gecko crashes on startup

[Describe test coverage new/current, TBPL]: m-c, locally

[Risks and why]: No risk; three-line patch only fixes the bug.

[String/UUID change made/needed]: None

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8495649 [details] [diff] [review]
Prevent using our own handler as system handler (v1)

Beta+

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/967cb2edcd52