Closed Bug 1073328 Opened 5 years ago Closed 5 years ago

Only use actual system uncaught handler

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 35
Tracking Status
firefox34 --- fixed
firefox35 --- fixed

People

(Reporter: jchen, Assigned: jchen)

Details

Attachments

(1 file)

Right now we get the system uncaught handler in GeckoApp.onCreate through GeckoAppShell.registerGlobalExceptionHandler, but if GeckoApp.onCreate is called multiple times, we end up grabbing our own handler as the system handler.
I've only seen this in developer builds, but we should fix it by grabbing the system handler only once.
Attachment #8495649 - Flags: review?(snorp)
Comment on attachment 8495649 [details] [diff] [review]
Prevent using our own handler as system handler (v1)

Review of attachment 8495649 [details] [diff] [review]:
-----------------------------------------------------------------

oops :)
Attachment #8495649 - Flags: review?(snorp) → review+
https://hg.mozilla.org/mozilla-central/rev/4793e12b9720
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Comment on attachment 8495649 [details] [diff] [review]
Prevent using our own handler as system handler (v1)

Approval Request Comment

[Feature/regressing bug #]: bug 1066175

[User impact if declined]: Hang in rare situations when Gecko crashes on startup

[Describe test coverage new/current, TBPL]: m-c, locally

[Risks and why]: No risk; three-line patch only fixes the bug.

[String/UUID change made/needed]: None
Attachment #8495649 - Flags: approval-mozilla-beta?
Comment on attachment 8495649 [details] [diff] [review]
Prevent using our own handler as system handler (v1)

Beta+
Attachment #8495649 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.