1073356 - [Calendar] Wobbly Refresh Icon Animation

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[James Burke [:jrburke]]

This is a sibling to bug 1069992, the wobbly email refresh icon, since they used similar layouts. Quoting from that bug:

"When you tap the refresh icon in the toolbar in [Calendar], the rotating animation is wobbly (not smooth).  It's rotational center is off."

I believe the root cause is similar to email: the root cause of one of the dimensions in the rotation being 100%.

I have a fix, will attach pull request shortly.

Comment 1

[James Burke [:jrburke]]

Attachment: GitHub pull request

Sets an explicit width/height on element containing the icon so that the rotation animation is not wobbly/off-center.

Not a rush, just setting choosing a reviewer since the patch is available. However, I appreciate the calendar folks are in the middle of some bigger work, so I expect this will be low priority for the moment. Feel free to switch off review for a bit if that helps.

Comment 2

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8495688 [details] [review]
GitHub pull request

LGTM!

Comment 3

[James Burke [:jrburke]]

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/bfd6d55f5bf176569b607903b8495c30059e403d

from pull request:
https://github.com/mozilla-b2g/gaia/pull/24456

Comment 4

[James Burke [:jrburke]]

Comment on attachment 8495688 [details] [review]
GitHub pull request

[Approval Request Comment]

[Bug caused by] (feature/regressing bug #):
Bug 940512: use drawer for calendar

[User impact] if declined:
A wobbly refresh icon when it rotates, looks less polished once you notice it.

[Testing completed]:
Tested on flame device.

[Risk to taking this patch] (and alternatives if risky):
Very low. Just a CSS bounds change along with a selector target change to match targeting the inner icon element that now has the bounds set on it. If there were any problem, it would be immediately visible.

[String changes made]:
none

Comment 5

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/18796314ba5ed354bbce12a7dd607c08a1ffddb8

Comment 6

[Edward Chen[:edchen]]

[Environment]
Gaia-Rev        d18e130216cd3960cd327179364d9f71e42debda
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/610ee0e6a776
Build-ID        20141012161201
Version         34.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20140925.192608
FW-Date         Thu Sep 25 19:26:18 EDT 2014
Bootloader      L1TC10011800

[Result]
PASS