1073378 - Lightweight themes are broken again

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Cristina Madaras, QA [:CristinaM]]

Environment:
Device: Asus Transformer Pad TF300T (Android 4.2.1)
Build: Firefox for Android 35.0a1 (2014-09-25)

Steps to reproduce:
1. Go to www.addons.mozilla.org;
2. Go to 'Themes' section and install one theme.

Expected results:
'Try it on' and 'Keep it' apply the chosen theme.

Actual results:
'Try it on' and 'Keep it' do not apply the chosen theme.

Regression window:
Last good: 2014-09-23
First bad: 2014-09-24

Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=790f41c631cc&tochange=1e2993c99323

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

This was broken by Bug 1050080. Will be temporarily fixed by Bug 1073359 (a partial backout). Will be permanently fixed by Bug 1072744.

Comment 2

[Matthew N. [:MattN]]

Can you confirm this was fixed by bug 1073359 and close the bug?

Comment 3

[Cristina Madaras, QA [:CristinaM]]

Both options 'Try it on' and 'Keep it' work as expected and apply the chosen theme on
Build: Firefox for Android 35.0a1
Device: Nexus 4 (Android 4.4.4)

Comment 4

[u279076]

Verified fixed by bug 1073359 based on comment 3.

Nominating to track since this was a regression that we reintroduced.

Comment 5

[u279076]

Since this has bitten us once before, do we have in-testsuite coverage to test this?

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #5)
> Since this has bitten us once before, do we have in-testsuite coverage to
> test this?

I'm not sure if this bustage could have been caught with a test since with requires installing from AMO, but maybe we could. We need to look at how Desktop is testing the whitelist permissions.

Even if this particular bustage can't be easily tested, we could try to add lightweight theme tests for other features.

Comment 7

[u279076]

On Desktop we have Mozmill tests for lightweight themes. I'm not sure if those pull in themes from AMO, there might be a locally stored test theme on mozqa.com. I'd have to double check that.

If we had something similar for Mobile tests would AMO still be required?

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #7)
> On Desktop we have Mozmill tests for lightweight themes. I'm not sure if
> those pull in themes from AMO, there might be a locally stored test theme on
> mozqa.com. I'd have to double check that.
> 
> If we had something similar for Mobile tests would AMO still be required?

We can't use MozMill but we can use the approach to test LWTs in general and I think we should add some. This particular bug might have needed a download from AMO to trigger, since it dealt with whitelisting permissions.

Comment 9

[u279076]

Mark, do you think that's something we can do in the Dev testsuite or would should I toss this over to the QA automation team for consideration?

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #9)
> Mark, do you think that's something we can do in the Dev testsuite or would
> should I toss this over to the QA automation team for consideration?

I'd open a new bug (Add basic LWT tests) and, in this case, assign to me :)

Comment 11

[u279076]

(In reply to Mark Finkle (:mfinkle) from comment #10)
> I'd open a new bug (Add basic LWT tests) and, in this case, assign to me :)

Thanks Mark, I've gone ahead and filed bug 1096307.