107341 - Cleanup gfx/src/xlib/

Status: RESOLVED FIXED

(Core :: XUL, enhancement)

Description

[Roland Mainz]

Clean-up gfx/src/xlib and gfx/src/xprint a little bit, get rid of unneccesary
|USE_XPRINT| usage ...

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Platform=All implies OS=All

Comment 2

[Roland Mainz]

Accepting bug ...

----

OS = All - but restricted to platforms which use X11 ...

Comment 3

[Roland Mainz]

Attachment: Patch for 2001-10-26-08-trunk

Comment 4

[Roland Mainz]

Filed patch, introducing three new files:
- mozilla/gfx/src/xlib/nsRenderingContextXlib.cpp 
  was cut into:
  - mozilla/gfx/src/xlib/nsRenderingContextXlib.cpp
  - mozilla/gfx/src/xprint/nsRenderingContextXp.cpp

- mozilla/gfx/src/xlib/nsRenderingContextXlib.h
  was cut into:
  - mozilla/gfx/src/xlib/nsRenderingContextXlib.h
  - mozilla/gfx/src/xlib/nsDeviceContextX.h
  - mozilla/gfx/src/xprint/nsRenderingContextXp.h

Requesting r=/sr= ...

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

r=biesi if you fix the issues we discussed at IRC #mozilla

Comment 6

[Roland Mainz]

Attachment: New patch for 2001-10-26-08-trunk to match r=biesi

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 55545 [details] [diff] [review]
New patch for 2001-10-26-08-trunk to match r=biesi

r=biesi

Note that I have not checked if the patch does compile

Comment 8

[Roland Mainz]

> r=biesi

Thanks!

> Note that I have not checked if the patch does compile

Well... it compiles on Linux and Solaris SPARC. cut&paste+fix_compiler_error
hacking like this should not cause much trouble... :-)

Comment 9

[pocemit]

great to see xlib code finally being separated from Xprint again.
great work, gisburn.

r=pocemit

Comment 10

[Roland Mainz]

pocemit:
This is no "logical" seperation - nsRenderingContextXp is still a subclass of
nsRenderingContextXlib. 
I just moved them to seperate files to make you happy... :-)

Comment 11

[Christopher Blizzard (:blizzard)]

Comment on attachment 55545 [details] [diff] [review]
New patch for 2001-10-26-08-trunk to match r=biesi

sr=blizzard

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

Fix checked in for gisburn