Closed
Bug 1073425
Opened 11 years ago
Closed 11 years ago
GonkNativeWindow::mNewFrameCallback not initialized on JB & KK.
Categories
(Core Graveyard :: Widget: Gonk, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla35
People
(Reporter: jhlin, Assigned: jhlin)
Details
Attachments
(1 file, 1 obsolete file)
|
1.71 KB,
patch
|
jhlin
:
review+
|
Details | Diff | Splinter Review |
If GonkNativeWindow::setNewFrameCallback() is not called, GonkNativeWindow::onFrameAvailable() would get Segmentation fault.
BTW, it's initialized to nullptr in the constructor on ICS.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8495831 -
Flags: review?(sotaro.ikeda.g)
|
||
Updated•11 years ago
|
Component: General → Widget: Gonk
Product: Firefox → Core
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8495831 [details] [diff] [review]
Initialize mNewFrameCallback in constructor.
Review of attachment 8495831 [details] [diff] [review]:
-----------------------------------------------------------------
Good catch!
Attachment #8495831 -
Flags: review?(sotaro.ikeda.g) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Carry forward r+ and update commit message.
Try result: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=84d949c83481
Attachment #8495831 -
Attachment is obsolete: true
Attachment #8496660 -
Flags: review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Assignee: nobody → jolin
Keywords: checkin-needed
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•