GonkNativeWindow::mNewFrameCallback not initialized on JB & KK.

RESOLVED FIXED in mozilla35

Status

defect
RESOLVED FIXED
5 years ago
9 months ago

People

(Reporter: jhlin, Assigned: jhlin)

Tracking

unspecified
mozilla35
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

If GonkNativeWindow::setNewFrameCallback() is not called, GonkNativeWindow::onFrameAvailable() would get Segmentation fault.

BTW, it's initialized to nullptr in the constructor on ICS.
Attachment #8495831 - Flags: review?(sotaro.ikeda.g)
Component: General → Widget: Gonk
Product: Firefox → Core
Comment on attachment 8495831 [details] [diff] [review]
Initialize mNewFrameCallback in constructor.

Review of attachment 8495831 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch!
Attachment #8495831 - Flags: review?(sotaro.ikeda.g) → review+
Carry forward r+ and update commit message.

Try result: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=84d949c83481
Attachment #8495831 - Attachment is obsolete: true
Attachment #8496660 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4578cddde9f7
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.