Update launch atom to work for apps that use hash in the src

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
4 years ago
8 months ago

People

(Reporter: viorela, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
When we use an app sometimes we may change its URL/iframe's src while using it. 
We have the scenario of Cost Control app, where its URL changed with an anchor tag on the end of it after part of the app was navigated to.

When the app was launched the second time (although it was only open in the background), the atom's expected launch_path does not match the src of the app and the atom times out. The atom can only handle the default expected launch path, not that of a running app.

We need to update our atom to handle the case when there's a hash added to an app's src.
And also update the existing unit test https://github.com/mozilla-b2g/gaia/blob/055c380b17ae0b7e18f4886d3988eca96d6c2048/tests/python/gaia-ui-tests/gaiatest/tests/unit/test_warm_launch.py to append a hash string at the end.
(Reporter)

Comment 1

4 years ago
Created attachment 8495902 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24470
Attachment #8495902 - Flags: review?(zcampbell)
Attachment #8495902 - Flags: review?(robert.chira)
Attachment #8495902 - Flags: review?(florin.strugariu)
(Reporter)

Comment 2

4 years ago
Dave, can you, please, give more info about how should we modify the unit test?
In order to get a hash added to the src, we need to navigate through the Cost Control first time use steps.
Is that what I should do?
Flags: needinfo?(dave.hunt)
Attachment #8495902 - Flags: review?(robert.chira) → review+
(In reply to Viorela Ioia [:viorela] from comment #2)
> Dave, can you, please, give more info about how should we modify the unit
> test?
> In order to get a hash added to the src, we need to navigate through the
> Cost Control first time use steps.
> Is that what I should do?

Can you not just execute some JavaScript to append #something to the end of the Window location?
Flags: needinfo?(dave.hunt)

Comment 4

4 years ago
Comment on attachment 8495902 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24470

r-, this is causing apps launched through a launch path to fail to launch on TBPL.

I also think test_warm_launch should use an app that works on desktopb2g so we can continue to run that test on TBPL.
Attachment #8495902 - Flags: review?(zcampbell)
Attachment #8495902 - Flags: review?(florin.strugariu)
Attachment #8495902 - Flags: review-
Attachment #8495902 - Flags: review+
QA Whiteboard: [fxosqa-auto-backlog+]

Comment 5

8 months ago
Firefox OS is not being worked on
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.