1073446 - Object.preventExtensions() should return its argument with no conversion when the argument is a primitive value

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[ziyunfei]

js> Object.preventExtensions("foo")
TypeError: "foo" is not an object
// should return "foo" in ES6

Comment 1

[ziyunfei]

https://tbpl.mozilla.org/?tree=Try&rev=5bb375168e52

Comment 2

[ziyunfei]

Attachment: bug-1073446.patch

Comment 3

[Till Schneidereit [:till]]

Comment on attachment 8495867 [details] [diff] [review]
bug-1073446.patch

Review of attachment 8495867 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks!

Please do a one-platform try run as described earlier, post the URL in the bug and then set checkin-needed once that turns up green. (And if you're ever unsure about what the try results mean, either ask in the bug or ping me in the #jsapi IRC channel. Reading try results is more of an art than a science at times.)

Comment 4

[Carsten Book [:Tomcat]]

Hi, could you provide a try run for this change, thanks!

Comment 5

[ziyunfei]

(In reply to Carsten Book [:Tomcat] from comment #4)
> Hi, could you provide a try run for this change, thanks!

This one: https://tbpl.mozilla.org/?tree=Try&rev=5bb375168e52

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f3599125b8a5

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f3599125b8a5