Closed
Bug 1073446
Opened 10 years ago
Closed 10 years ago
Object.preventExtensions() should return its argument with no conversion when the argument is a primitive value
Categories
(Core :: JavaScript: Standard Library, defect)
Core
JavaScript: Standard Library
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: 446240525, Assigned: 446240525)
References
Details
(Keywords: dev-doc-complete, Whiteboard: [DocArea=JS])
Attachments
(1 file)
|
3.51 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
js> Object.preventExtensions("foo")
TypeError: "foo" is not an object
// should return "foo" in ES6
Summary: Object.preventExtensions() should return it's argument with no conversion when the argument is a primitive value → Object.preventExtensions() should return its argument with no conversion when the argument is a primitive value
Attachment #8495867 -
Flags: review?(till)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8495867 [details] [diff] [review] bug-1073446.patch Review of attachment 8495867 [details] [diff] [review]: ----------------------------------------------------------------- Nice, thanks! Please do a one-platform try run as described earlier, post the URL in the bug and then set checkin-needed once that turns up green. (And if you're ever unsure about what the try results mean, either ask in the bug or ping me in the #jsapi IRC channel. Reading try results is more of an art than a science at times.)
Attachment #8495867 -
Flags: review?(till) → review+
|
||
Comment 4•10 years ago
|
||
Hi, could you provide a try run for this change, thanks!
Keywords: checkin-needed
(In reply to Carsten Book [:Tomcat] from comment #4) > Hi, could you provide a try run for this change, thanks! This one: https://tbpl.mozilla.org/?tree=Try&rev=5bb375168e52
Keywords: checkin-needed
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3599125b8a5
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f3599125b8a5
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•