Marionette should allow setting of capabilities from a new session

RESOLVED FIXED in mozilla36

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: automatedtester, Assigned: automatedtester)

Tracking

(Blocks 1 bug, {pi-marionette-spec})

unspecified
mozilla36
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(1 attachment)

Assignee

Description

5 years ago
WebDriver allows people to pass through capabilities that the browser should support and if they don't then reject them
Assignee

Updated

5 years ago
Assignee: nobody → dburns
Status: NEW → ASSIGNED
Assignee

Updated

5 years ago
Blocks: 1081316
Comment on attachment 8503408 [details] [diff] [review]
Add the ability to set capabilities into Marionette

Review of attachment 8503408 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/client/marionette/tests/unit/test_capabilities.py
@@ +54,5 @@
>          self.assertEqual(self.caps["version"], self.appinfo["version"])
> +
> +    def test_we_can_pass_in_capabilities_on_session_start(self):
> +        self.marionette.delete_session()
> +        capabilities = {"somethingAwesome": "cake"}

yay, cake!

::: testing/marionette/marionette-listener.js
@@ +94,5 @@
>   * Called when listener is first started up.
>   * The listener sends its unique window ID and its current URI to the actor.
>   * If the actor returns an ID, we start the listeners. Otherwise, nothing happens.
>   */
> +function registerSelf(message) {

Was this change left over by mistake?  We never call registerSelf() with any parameters.

::: testing/marionette/marionette-server.js
@@ +616,5 @@
> +    this.sendResponse(this.sessionCapabilities, this.command_id);
> +  },
> +
> +  /**
> +   * Update the sessionCapabilities object with the keys that the

Looks like a truncated sentence here.

@@ +626,5 @@
> +   */
> +  setSessionCapabilities: function MDA_setSessionCapabilities (capabilities) {
> +    this.command_id = this.getCommandId();
> +    var tempCapabilities = {};
> +    logger.info("Caps argument is " + JSON.stringify(capabilities));

This logging is probably redundant with the logging added in newSession().
Attachment #8503408 - Flags: review?(jgriffin) → review+
https://hg.mozilla.org/mozilla-central/rev/c782a908f89c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.