1073539 - Marionette should allow setting of capabilities from a new session

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[David Burns :automatedtester]

WebDriver allows people to pass through capabilities that the browser should support and if they don't then reject them

Comment 1

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=78a4bc887404

Comment 2

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=71db950b6b89

Comment 3

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=8f34637c2d3e

Comment 4

[David Burns :automatedtester]

Attachment: Add the ability to set capabilities into Marionette

Comment 5

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8503408 [details] [diff] [review]
Add the ability to set capabilities into Marionette

Review of attachment 8503408 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/client/marionette/tests/unit/test_capabilities.py
@@ +54,5 @@
>          self.assertEqual(self.caps["version"], self.appinfo["version"])
> +
> +    def test_we_can_pass_in_capabilities_on_session_start(self):
> +        self.marionette.delete_session()
> +        capabilities = {"somethingAwesome": "cake"}

yay, cake!

::: testing/marionette/marionette-listener.js
@@ +94,5 @@
>   * Called when listener is first started up.
>   * The listener sends its unique window ID and its current URI to the actor.
>   * If the actor returns an ID, we start the listeners. Otherwise, nothing happens.
>   */
> +function registerSelf(message) {

Was this change left over by mistake?  We never call registerSelf() with any parameters.

::: testing/marionette/marionette-server.js
@@ +616,5 @@
> +    this.sendResponse(this.sessionCapabilities, this.command_id);
> +  },
> +
> +  /**
> +   * Update the sessionCapabilities object with the keys that the

Looks like a truncated sentence here.

@@ +626,5 @@
> +   */
> +  setSessionCapabilities: function MDA_setSessionCapabilities (capabilities) {
> +    this.command_id = this.getCommandId();
> +    var tempCapabilities = {};
> +    logger.info("Caps argument is " + JSON.stringify(capabilities));

This logging is probably redundant with the logging added in newSession().

Comment 6

[David Burns :automatedtester]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c782a908f89c

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c782a908f89c