Closed
Bug 1073539
Opened 10 years ago
Closed 10 years ago
Marionette should allow setting of capabilities from a new session
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: automatedtester, Assigned: automatedtester)
References
(Blocks 1 open bug, )
Details
(Keywords: pi-marionette-spec)
Attachments
(1 file)
8.60 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
WebDriver allows people to pass through capabilities that the browser should support and if they don't then reject them
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 1•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=78a4bc887404
Assignee | ||
Comment 2•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=71db950b6b89
Assignee | ||
Comment 3•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=8f34637c2d3e
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8503408 -
Flags: review?(jgriffin)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → dburns
Status: NEW → ASSIGNED
Comment 5•10 years ago
|
||
Comment on attachment 8503408 [details] [diff] [review] Add the ability to set capabilities into Marionette Review of attachment 8503408 [details] [diff] [review]: ----------------------------------------------------------------- ::: testing/marionette/client/marionette/tests/unit/test_capabilities.py @@ +54,5 @@ > self.assertEqual(self.caps["version"], self.appinfo["version"]) > + > + def test_we_can_pass_in_capabilities_on_session_start(self): > + self.marionette.delete_session() > + capabilities = {"somethingAwesome": "cake"} yay, cake! ::: testing/marionette/marionette-listener.js @@ +94,5 @@ > * Called when listener is first started up. > * The listener sends its unique window ID and its current URI to the actor. > * If the actor returns an ID, we start the listeners. Otherwise, nothing happens. > */ > +function registerSelf(message) { Was this change left over by mistake? We never call registerSelf() with any parameters. ::: testing/marionette/marionette-server.js @@ +616,5 @@ > + this.sendResponse(this.sessionCapabilities, this.command_id); > + }, > + > + /** > + * Update the sessionCapabilities object with the keys that the Looks like a truncated sentence here. @@ +626,5 @@ > + */ > + setSessionCapabilities: function MDA_setSessionCapabilities (capabilities) { > + this.command_id = this.getCommandId(); > + var tempCapabilities = {}; > + logger.info("Caps argument is " + JSON.stringify(capabilities)); This logging is probably redundant with the logging added in newSession().
Attachment #8503408 -
Flags: review?(jgriffin) → review+
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c782a908f89c
https://hg.mozilla.org/mozilla-central/rev/c782a908f89c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•