Closed
Bug 1073566
Opened 11 years ago
Closed 11 years ago
[Utility Tray] Alignment of header text
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(b2g-v2.1 verified, b2g-v2.2 verified)
VERIFIED
FIXED
2.1 S6 (10oct)
People
(Reporter: epang, Assigned: gmarty)
Details
(Keywords: polish, Whiteboard: [systemsfe])
Attachments
(2 files)
|
58.89 KB,
image/jpeg
|
Details | |
|
46 bytes,
text/x-github-pull-request
|
etienne
:
review+
epang
:
ui-review+
fabrice
:
approval-gaia-v2.1+
|
Details | Review |
notification header.jpg
Hi Guillaume,
Can you adjust the header text so it's base aligned with the 'clear all' button? Currently it's sitting too high and feels out of line with the icon and clear all.
Thanks!
|
Assignee | |
Comment 1•11 years ago
|
||
There you go Eric. How does it look now?
Attachment #8496786 -
Flags: ui-review?(epang)
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 8496786 [details] [review]
Github PR
Looks great now, thanks for the quick fix!
Attachment #8496786 -
Flags: ui-review?(epang) → ui-review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8496786 [details] [review]
Github PR
Etienne, this patch is very trivial. Can you have a look? Thanks.
Attachment #8496786 -
Flags: review?(etienne)
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8496786 [details] [review]
Github PR
stamp
Attachment #8496786 -
Flags: review?(etienne) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Landed in master as of https://github.com/mozilla-b2g/gaia/commit/09ffd07964de1ad15d7ab34ab89c78bdf223605a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•11 years ago
|
||
Comment on attachment 8496786 [details] [review]
Github PR
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Utility tray visual refresh
[User impact] if declined: Bad visual aspect
[Testing completed]: Manual testing required
[Risk to taking this patch] (and alternatives if risky): None as it is just a simple CSS change
[String changes made]: none
Attachment #8496786 -
Flags: approval-gaia-v2.1?(bbajaj)
|
||
Updated•11 years ago
|
Attachment #8496786 -
Flags: approval-gaia-v2.1?(bbajaj) → approval-gaia-v2.1+
|
||
Comment 7•11 years ago
|
||
Needs rebasing for v2.1 uplift.
status-b2g-v2.1:
--- → affected
status-b2g-v2.2:
--- → fixed
Flags: needinfo?(gmarty)
Keywords: branch-patch-needed
Target Milestone: --- → 2.1 S6 (10oct)
|
|
Assignee | |
Comment 8•11 years ago
|
||
Hi Ryan, here's a PR for the v2.1 branch:
https://github.com/mozilla-b2g/gaia/pull/24747
Flags: needinfo?(gmarty) → needinfo?(ryanvm)
|
|
||
Comment 9•11 years ago
|
||
|
||
Comment 10•11 years ago
|
||
This issue is verified fixed on Flame 2.1 and 2.2.
Result: The "Notifications" string is aligned correctly with the icon and "Clear all".
Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141103001220
Gaia: 027a7de0c95320cea0579bfd1a4ceef3e9038f34
Gecko: ffecb2be228b
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141103040202
Gaia: bc168c17474dabbcceaa349e9bc7c95654435aec
Gecko: 5999e92e89ff
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
|
||
Updated•11 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in
before you can comment on or make changes to this bug.
Description
•