Closed
Bug 1073608
Opened 11 years ago
Closed 11 years ago
Remove Object.prototype.extend
Categories
(Firefox OS Graveyard :: Gaia::Cost Control, defect)
Firefox OS Graveyard
Gaia::Cost Control
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S6 (10oct)
People
(Reporter: stas, Assigned: kgrandon)
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
The Usage app adds a method on Object.prototype which is a bad practice and makes iterating over objects' keys more hazardous than it should be. This is particularly troublesome for the code in shared/ which unexpectedly gets this new method on all its objects.
I suggest this method be moved to a regular standalone function.
|
Assignee | |
Comment 1•11 years ago
|
||
It looks like it was added here, but I can't seem to find any references to it: https://github.com/mozilla-b2g/gaia/commit/bdde032570b236689ce01e23fed65cb8c518f495
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8496303 [details] [review]
Github pull request
Salva or Mai - could one of you review this? I couldn't find any usage in the Usage app. Thanks!
Attachment #8496303 -
Flags: review?(salva)
Attachment #8496303 -
Flags: review?(mri)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Taking for now.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S5 (26sep)
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8496303 [details] [review]
Github pull request
The function is no longer used. Let's get rid of it.
Thank you :stas for the catch and Kevin for the patch.
Attachment #8496303 -
Flags: review?(salva)
Attachment #8496303 -
Flags: review?(mri)
Attachment #8496303 -
Flags: review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
Thanks for the review!
In master: https://github.com/mozilla-b2g/gaia/commit/d66bf704c0c0014ab518f041cd89a2b7e841be31
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: 2.1 S5 (26sep) → 2.1 S6 (10oct)
You need to log in
before you can comment on or make changes to this bug.
Description
•