Closed Bug 1073692 Opened 10 years ago Closed 10 years ago

Search suggestions popup on about:home/about:newtab should show each result according to its text direction

Categories

(Firefox :: Search, defect)

defect
Not set
normal
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 35
Iteration:
35.3

People

(Reporter: adw, Assigned: adw)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
dir is set on the table, which means that the first result in the popup determines the text direction of the whole popup.  So if the popup contains both RTL and LTR text, one or the other will be shown incorrectly.

Instead dir should be set on each row.
Attachment #8496249 - Flags: review?(ehsan.akhgari)
Flags: qe-verify-
Flags: firefox-backlog+
Summary: Search suggestions popup on about:home/about:new should correctly show each result according to its text direction by setting dir attribute on table rows → Search suggestions popup on about:home/about:newtab should show each result according to its text direction
Attachment #8496249 - Flags: review?(ehsan.akhgari) → review+
Iteration: 35.2 → 35.3
Keywords: checkin-needed
Needs a Try run and a patch with commit information included.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/41085ca48e5a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
You need to log in before you can comment on or make changes to this bug.