Closed Bug 1073704 Opened 5 years ago Closed 5 years ago

Input touch resampling is broken

Categories

(Core Graveyard :: Widget: Gonk, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla35

People

(Reporter: boris, Assigned: mwu)

References

Details

Attachments

(2 files)

Attached video input_resample.mp4
After we landed bug 1072645, touch re-sampling may be broken. ex. Scrolling on Homescreen is not correct, and you cannot select any option in Settings. This bug also has impact on Project Silk.

Please turn on the preferences, gfx.frameuniformity.hw-vsync and gfx.touch.resample, and you can reproduce the problem. Jerry recorded the video for this bug, please check the attachment.
Blocks: 1062331
Blocks: 987529
Depends on: 1072645
Blocks: Silk
Accidentally removed too much code. I think clearing the move queue here is wrong - should be done on the input thread instead. But, this fixes things for now. Should probably also look for coalesced touch ups, but the old code had the same issue.
Assignee: nobody → mwu
Attachment #8496299 - Flags: review?(bugmail.mozilla)
See Also: → 1069037
Attachment #8496299 - Flags: review?(bugmail.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/bcf35e3725f0
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.