Closed
Bug 1073712
Opened 10 years ago
Closed 10 years ago
WebMReader needs to include "prprf.h" when PR_LOGGING is enabled
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(1 file)
903 bytes,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
I get build failures if PR_LOGGING is defined when building WebMReader due to the use of PR_snprintf and friends without including the necessary header.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8496286 -
Flags: review?(cpearce)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Updated•10 years ago
|
Attachment #8496286 -
Flags: review?(cpearce) → review+
Assignee | ||
Comment 2•10 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/3babe1151a7f
Assignee | ||
Updated•10 years ago
|
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3babe1151a7f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Comment 4•10 years ago
|
||
I don't know how this happened to build after bug 806819 landed, but somehow, it started failing badly when bug 1060179 landed. https://treeherder.mozilla.org/ui/logviewer.html#?job_id=2876031&repo=mozilla-inbound Landed a fixup: https://hg.mozilla.org/integration/mozilla-inbound/rev/a5a91bfe0013
Comment 5•10 years ago
|
||
And a fixup for the fixup: https://hg.mozilla.org/integration/mozilla-inbound/rev/48ba505ebcbd
https://hg.mozilla.org/mozilla-central/rev/a5a91bfe0013 https://hg.mozilla.org/mozilla-central/rev/48ba505ebcbd
You need to log in
before you can comment on or make changes to this bug.
Description
•