Closed
Bug 1073776
Opened 10 years ago
Closed 10 years ago
Tapping on urlbar after performing search shows URL, not search term
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(firefox35 verified, fennec35+)
VERIFIED
FIXED
Firefox 35
People
(Reporter: Margaret, Assigned: wesj)
References
Details
(Keywords: regression, reproducible)
Attachments
(1 file, 1 obsolete file)
1.08 KB,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
This might be a problem with Yahoo redirecting searches, but I noticed it with Google as well on my tablet. Seems like a regression.
Assignee | ||
Comment 1•10 years ago
|
||
Google still works on my phone.
Updated•10 years ago
|
tracking-fennec: --- → ?
Reporter | ||
Comment 2•10 years ago
|
||
With Google on my N7 it works in Aurora, but not in Nightly. Lucas, could this be a regression from the new tablet work (I'm testing with the new tablet UI enabled).
Flags: needinfo?(lucasr.at.mozilla)
Comment 3•10 years ago
|
||
(In reply to :Margaret Leibovic from comment #2) > With Google on my N7 it works in Aurora, but not in Nightly. > > Lucas, could this be a regression from the new tablet work (I'm testing with > the new tablet UI enabled). It could be, even though I can't think of a specific change that might have caused this. Mike, any ideas? A regression window would be useful here.
Flags: needinfo?(lucasr.at.mozilla)
Keywords: regressionwindow-wanted
Updated•10 years ago
|
Flags: needinfo?(michael.l.comella)
Comment 4•10 years ago
|
||
Regression window: Last good: 2014-09-17 First bad: 2014-09-18 Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8252eae8278c&tochange=426497473505
Keywords: regressionwindow-wanted
Comment 5•10 years ago
|
||
Went through the commits in regression window. This is the most likely suspect: Bug 1042199 - Show a search box on error pages. r=margaret https://hg.mozilla.org/mozilla-central/rev/a4b979000940
Flags: needinfo?(wjohnston)
Flags: needinfo?(michael.l.comella)
Flags: needinfo?(margaret.leibovic)
Updated•10 years ago
|
Blocks: 1042199
Keywords: regression,
reproducible
Reporter | ||
Comment 6•10 years ago
|
||
(In reply to Lucas Rocha (:lucasr) from comment #5) > Went through the commits in regression window. This is the most likely > suspect: > > Bug 1042199 - Show a search box on error pages. r=margaret > https://hg.mozilla.org/mozilla-central/rev/a4b979000940 Yeah, I very much suspect this. We'll need to dig into this. Wes, can you reproduce this? Can you look into it?
Flags: needinfo?(margaret.leibovic)
Assignee | ||
Comment 7•10 years ago
|
||
Simple fix.
Attachment #8498442 -
Flags: review?(margaret.leibovic)
Flags: needinfo?(wjohnston)
Assignee | ||
Comment 8•10 years ago
|
||
Attachment #8498442 -
Attachment is obsolete: true
Attachment #8498442 -
Flags: review?(margaret.leibovic)
Attachment #8498443 -
Flags: review?(margaret.leibovic)
Reporter | ||
Comment 9•10 years ago
|
||
Comment on attachment 8498443 [details] [diff] [review] Patch Review of attachment 8498443 [details] [diff] [review]: ----------------------------------------------------------------- Doh. http://hg.mozilla.org/mozilla-central/diff/a4b979000940/mobile/android/chrome/content/browser.js#l1.59
Attachment #8498443 -
Flags: review?(margaret.leibovic) → review+
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → wjohnston
Assignee | ||
Comment 10•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/497e4c92e680
Updated•10 years ago
|
tracking-fennec: ? → 35+
Comment 11•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/497e4c92e680
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Comment 12•10 years ago
|
||
Verified as fixed in: Build: Firefox for Android 35.0a1 (2014-10-05) Device: Nexus 4 (Android 4.4.4)
Status: RESOLVED → VERIFIED
status-firefox35:
--- → verified
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•