Closed Bug 1073776 Opened 10 years ago Closed 10 years ago

Tapping on urlbar after performing search shows URL, not search term

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

35 Branch
All
Android
defect
Not set
normal

Tracking

(firefox35 verified, fennec35+)

VERIFIED FIXED
Firefox 35
Tracking Status
firefox35 --- verified
fennec 35+ ---

People

(Reporter: Margaret, Assigned: wesj)

References

Details

(Keywords: regression, reproducible)

Attachments

(1 file, 1 obsolete file)

This might be a problem with Yahoo redirecting searches, but I noticed it with Google as well on my tablet. Seems like a regression.
Google still works on my phone.
tracking-fennec: --- → ?
With Google on my N7 it works in Aurora, but not in Nightly.

Lucas, could this be a regression from the new tablet work (I'm testing with the new tablet UI enabled).
Flags: needinfo?(lucasr.at.mozilla)
(In reply to :Margaret Leibovic from comment #2)
> With Google on my N7 it works in Aurora, but not in Nightly.
> 
> Lucas, could this be a regression from the new tablet work (I'm testing with
> the new tablet UI enabled).

It could be, even though I can't think of a specific change that might have caused this. Mike, any ideas?

A regression window would be useful here.
Flags: needinfo?(lucasr.at.mozilla)
Flags: needinfo?(michael.l.comella)
Went through the commits in regression window. This is the most likely suspect:

Bug 1042199 - Show a search box on error pages. r=margaret
https://hg.mozilla.org/mozilla-central/rev/a4b979000940
Flags: needinfo?(wjohnston)
Flags: needinfo?(michael.l.comella)
Flags: needinfo?(margaret.leibovic)
(In reply to Lucas Rocha (:lucasr) from comment #5)
> Went through the commits in regression window. This is the most likely
> suspect:
> 
> Bug 1042199 - Show a search box on error pages. r=margaret
> https://hg.mozilla.org/mozilla-central/rev/a4b979000940

Yeah, I very much suspect this. We'll need to dig into this.

Wes, can you reproduce this? Can you look into it?
Flags: needinfo?(margaret.leibovic)
Attached patch Patch (obsolete) — Splinter Review
Simple fix.
Attachment #8498442 - Flags: review?(margaret.leibovic)
Flags: needinfo?(wjohnston)
Attached patch PatchSplinter Review
Attachment #8498442 - Attachment is obsolete: true
Attachment #8498442 - Flags: review?(margaret.leibovic)
Attachment #8498443 - Flags: review?(margaret.leibovic)
Comment on attachment 8498443 [details] [diff] [review]
Patch

Review of attachment 8498443 [details] [diff] [review]:
-----------------------------------------------------------------

Doh.
http://hg.mozilla.org/mozilla-central/diff/a4b979000940/mobile/android/chrome/content/browser.js#l1.59
Attachment #8498443 - Flags: review?(margaret.leibovic) → review+
Assignee: nobody → wjohnston
tracking-fennec: ? → 35+
https://hg.mozilla.org/mozilla-central/rev/497e4c92e680
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Verified as fixed in:
Build: Firefox for Android 35.0a1 (2014-10-05)
Device: Nexus 4 (Android 4.4.4)
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.