Closed
Bug 1073828
Opened 11 years ago
Closed 11 years ago
RestyleLogging.h usage of __LINE__ requires nested macros
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: dbaron, Assigned: heycam)
References
Details
Attachments
(1 file)
|
2.50 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
I see:
0:08.62 Warning: -Wshadow in /home/dbaron/builds/ssd/mozilla-central/obj/firefox-debugopt/dist/include/mozilla/RestyleLogging.h: shadowed declaration is here
0:08.62 ../../dist/include/mozilla/RestyleLogging.h:37:24: warning: shadowed declaration is here [-Wshadow]
0:08.62 AutoRestore<int32_t> ar_depth_##__LINE__(LoggingDepth());
This points out that the usage of __LINE__ in RestyleLogging.h isn't as intended; nested macros are needed.
|
Reporter | |
Updated•11 years ago
|
Summary: LOG_RESTYLE_INDENT usage of __LINE__ isn't as intended → RestyleLogging.h usage of __LINE__ requires nested macros
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Reporter | |
Updated•11 years ago
|
Attachment #8496501 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•