1073940 - Add icon for contact deletion to "icons-16x16.svg"

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P4)

Description

[:Paolo Amadini]

There is no icon for contact deletion in the "icons-16x16.svg" file, which is used by the context menu for contacts.

Comment 2

[:shell escalante]

Is this something we need from UX, that we are missing the icon file?  or is this a dev bug to fix?

Comment 3

[:Paolo Amadini]

(In reply to sescalante from comment #2)
> Is this something we need from UX, that we are missing the icon file?  or is
> this a dev bug to fix?

As far as I understand, this is a UX (missing asset) bug.

Comment 4

[:shell escalante]

hi darrin, let me know if i should be asking someone besides you - or asking you and sevaan or michael.  see the question in comment 3 - sounds like missing asset.

Comment 5

[Darrin Henein [:darrin]]

For (most) graphics/assets, Michael is our guy.

Comment 6

[Maire Reavy [:mreavy]]

Hi Mike -- Can you provide this asset to us today or tomorrow?

Comment 7

[Michael Maslaney [:mmaslaney] ([e-mail])]

Hi Maire, I'm slammed at the moment on another project, but can deliver the asset by EOD Thursday.

Comment 8

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: FX_Hello-glyph-delete-contact-16x16.svg

Attached, the delete contact glyph.

Comment 9

[Andrei Oprea [:andreio]]

Attachment: Add missing icon to loop contacts panel

Comment 10

[Maire Reavy [:mreavy]]

Moving P2->P3 (P3 is a "normal" bug that we want fixed for Fx36.)

Comment 11

[Maire Reavy [:mreavy]]

Meant to make this 37?

Comment 12

[Mark Banner (:standard8)]

Attachment: Add missing icon to loop contacts panel

Unbitrotted patch

Comment 13

[Mark Banner (:standard8)]

Attachment: Add missing icon to loop contacts panel

Now with ui-showcase update. Not sure why this never got review requested the first time around, but might as well get it added.

Comment 14

[Mike de Boer [:mikedeboer]]

Comment on attachment 8605107 [details] [diff] [review]
Add missing icon to loop contacts panel

Review of attachment 8605107 [details] [diff] [review]:
-----------------------------------------------------------------

So why didn't ui-showcase.js get generated? Do you have build-jsx silenced?

With the updated generated file, r=me!

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/cdf3daaf4230

Comment 16

[Mark Banner (:standard8)]

(In reply to Mike de Boer [:mikedeboer] from comment #14)
> So why didn't ui-showcase.js get generated? Do you have build-jsx silenced?

I just hadn't turned it on yet this morning ;-)

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cdf3daaf4230