1073962 - don't treat piped error events as un-handled

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Tomislav Jovanovic :zombie]

i'm breaking out mostly-independent changes from my big PR for bug 1058698..

when all events are piped from target A to target B (or simply when '*' catch-all handler is used), it doesn't make sense to treat 'error' events on target A as "unhandled" and print them out to console twice.

if the target B doesn't have a handler for 'error' event, it will still be printed, so there is no loss of information with this change..


also, i was surprised that EventTarget.off() method doesn't behave like the off() methods in event/core or jQuery.

i understand that was on purpose for EventTarget.removeListener() as that API is defined differently, but i think it makes sense for target.off() to remove all event listeners..

Comment 1

[Tomislav Jovanovic :zombie]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1659

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/2acf7c0e3b112566eb6f1bfada699cb96593fdbd
bug 1073962 - consider piped errors handled

https://github.com/mozilla/addon-sdk/commit/79a0c36ff30a5c55dd5e87427318d5a7a5716d5e
Merge pull request #1659 from zombie/1073962-catchall-error

bug 1073962 - consider piped errors handled r=@gozala