Closed
Bug 1073968
Opened 12 years ago
Closed 11 years ago
SM-Trunk: Under Modern neither reply nor new message possible
Categories
(SeaMonkey :: MailNews: Composition, defect)
Tracking
(seamonkey2.32 fixed, seamonkey2.33 fixed)
RESOLVED
FIXED
seamonkey2.33
People
(Reporter: h.figge, Assigned: neil)
Details
(Keywords: modern)
Attachments
(1 file)
|
2.10 KB,
patch
|
rsx11m.pub
:
review+
philip.chee
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
Using the theme Modern it is no longer possible to reply to a posting or create a new one on SM-Trunk. Regressin window or further description not necessary, because i was pointed to try a backout of Bug 1068188. That fixed the problem.
|
||
Comment 1•12 years ago
|
||
Maybe this bug can use the binding which will be added by bug 1066551. I'll depend this bug on it.
Depends on: 1066551
As it appears to be just a theme issue (port classic changes to modern), wouldn't it be better to amend the existing patch in bug 1066551 attachment 8492036 [details] [diff] [review] respectively?
The binding is introduced in mailnews/compose/content/menulistCompactBindings.xml but only used in the theme itself rather than in suite/mailnews/messenger.css where other bindings are bound.
Component: Search → MailNews: Composition
Keywords: modern
|
Assignee | |
Comment 3•12 years ago
|
||
Comment on attachment 8498524 [details] [diff] [review]
Proposed patch
Works fine for me on a Linux trunk build. The address-widget menus show up again and are functional for all selections. Except for the menulist-icon image, the code added here corresponds to what was removed in bug 1068188 attachment 8491607 [details] [diff] [review].
Attachment #8498524 -
Flags: review?(rsx11m.pub) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.32
Neil, this will have to land on comm-aurora as well (missed today's merge by 2hrs or so).
No SeaMonkey 2.33 flags yet, thus I can't adjust the flags accordingly.
status-seamonkey2.32:
--- → affected
status-seamonkey2.33:
--- → fixed
|
|
Assignee | |
Comment 7•11 years ago
|
||
Comment on attachment 8498524 [details] [diff] [review]
Proposed patch
[Approval Request Comment]
Regression caused by (bug #): 1068188
User impact if declined: Can't compose mail with the Modern theme
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None
Attachment #8498524 -
Flags: approval-comm-aurora?
|
||
Comment 8•11 years ago
|
||
Comment on attachment 8498524 [details] [diff] [review]
Proposed patch
a=me for comm-aurora
Attachment #8498524 -
Flags: approval-comm-aurora? → approval-comm-aurora+
|
|
Assignee | |
Comment 9•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Target Milestone: seamonkey2.32 → seamonkey2.33
You need to log in
before you can comment on or make changes to this bug.
Description
•