Closed
Bug 1073971
Opened 10 years ago
Closed 10 years ago
avoid some warnings in "about:" page used in page-mod tests
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla35
People
(Reporter: zombie, Assigned: zombie)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Updated•10 years ago
|
Blocks: 1058698
Summary: shut → avoid some warnings in "about:" page used in page-mod tests
|
|
Assignee | |
Comment 1•10 years ago
|
||
20 warnings logged:
console.log: addon-sdk: [JavaScript Error: "formatURLPref: Couldn't get pref:
app.releaseNotesURL" {file: "resource://gre/components/nsURLFormatter.js" line: 134}]
makes it hard to read the test logs..
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8496573 -
Flags: review?(evold)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → tomica+amo
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•10 years ago
|
||
(i'm breaking out mostly-independent changes from my big PR for bug 1058698..)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8496573 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1660
Thanks!
Looks good, just a minor nit to use a url more like `http://localhost/app-dummy/`
Attachment #8496573 -
Flags: review?(evold) → review-
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8496573 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1660
don't think it makes a difference -- this does not result in a network request, just a read from prefs assigned to a href of a link on the "about:" page, but whatever..
Attachment #8496573 -
Flags: review- → review?(evold)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8496573 -
Flags: review?(evold) → review?(jsantell)
|
||
Updated•10 years ago
|
Attachment #8496573 -
Flags: review?(jsantell) → review+
|
||
Comment 6•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/9f20e29e16b8ae0cd6a7f8781c8e4abb740ea7b4
bug 1073971 - avoid some warnings on about: page
https://github.com/mozilla/addon-sdk/commit/5fbe6782acec44badc8f6d6268d5ad37366e557e
Merge pull request #1660 from zombie/1073971-about-warnings
bug 1073971 - avoid some warnings on about: page, r=@jsantell
|
|
Assignee | |
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•