1074054 - Make getAnimationPlayers return players that are filling forwards

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Web Animations now says the getAnimationPlayers also returns animations that are filling forwards:

  http://w3c.github.io/web-animations/#dom-animatable-getanimationplayers

Comment 1

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: part 1 - Add Animation::IsInEffect

This patch adds a utility method to return if an animation is "in effect" or not
as defined by Web Animations:

  http://w3c.github.io/web-animations/#in-effect

It also moves the utility method for querying if an animation is "current"
(IsCurrent) to the .cpp file since it is fairly long. (Bug 1046055 makes one of
the callers of IsCurrent inline-able which should offset any cost introduced by
this no longer being inline-able.)

Comment 2

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: part 2 - Make Element::GetAnimationPlayers return in-effect animations too

This patch makes Element::GetAnimationPlayers return not only current animations
but also animations that have finished but are filling forwards. This brings the
implementation into line with recent changes to the Web Animations spec and
allows querying all the animations that are currently affecting an element or
which are scheduled to do so in the future.

Comment 3

[Brian Birtles (:birtles, Feb 26~ parental leave)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5bdbb954b43b

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8497281 [details] [diff] [review]
part 1 - Add Animation::IsInEffect

I don't understand the bits in the spec about what to do if there's a parent animation group.  (They don't make much sense to me.)  I presume we don't implement that concept yet?

r=dbaron if that's the case

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8497282 [details] [diff] [review]
part 2 - Make Element::GetAnimationPlayers return in-effect animations too

I presume you checked that the test fails without the patch?

r=dbaron if so

Comment 6

[Brian Birtles (:birtles, Feb 26~ parental leave)]

(In reply to David Baron [:dbaron] (UTC-7) (needinfo? for questions) from comment #4)
> Comment on attachment 8497281 [details] [diff] [review]
> part 1 - Add Animation::IsInEffect
> 
> I don't understand the bits in the spec about what to do if there's a parent
> animation group.  (They don't make much sense to me.)  I presume we don't
> implement that concept yet?

Yes, that's correct. Animation groups are much further down the track and will possibly be split into a later version of the spec.

(In reply to David Baron [:dbaron] (UTC-7) (needinfo? for questions) from comment #5)
> Comment on attachment 8497282 [details] [diff] [review]
> part 2 - Make Element::GetAnimationPlayers return in-effect animations too
> 
> I presume you checked that the test fails without the patch?

Yes.

Comment 7

[Brian Birtles (:birtles, Feb 26~ parental leave)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a4ecfff302a
https://hg.mozilla.org/integration/mozilla-inbound/rev/35e518128ca3

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3a4ecfff302a
https://hg.mozilla.org/mozilla-central/rev/35e518128ca3