Closed Bug 1074075 Opened 5 years ago Closed 5 years ago

[Gaia][Settings][Bluetooth] Refactor Bluetooth description in settings root panel

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

Product:
Firefox OS Graveyard
Component:
Bluetooth
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S6 (10oct)

People

(Reporter: iliu, Assigned: iliu)

References

Details

Attachments

(1 file)

pull request 24506
46 bytes, text/x-github-pull-request
arthurcc
: review+
Details | Review 
Before we implement Gaia::Settings::Bluetooth to support v2.0 API, we have to refactor the root panel for description of Bluetooth menu. And using AMD, MVVM modules to construct new code base to separate dependency issue from UI/mozBluetooth.
Since we have done some refactor work in Bug 1032071, I will reference patch of the older bug to work on this patch here.
Status: NEW → ASSIGNED
Attached file pull request 24506 — 
Arthur, could you please help to review my pr for refactor work? Thanks.
Attachment #8497382 - Flags: review?(arthur.chen)
Comment on attachment 8497382 [details] [review]
pull request 24506

Sorry for the late review. The patch looks good to me. r=me with the nit addressed, thanks!
Attachment #8497382 - Flags: review?(arthur.chen) → review+
Thanks for Arthur's reviewing effort. The patch will be landed while tests are passed on try-server.
Since the pr is landed, we can close the issue now.

Gaia/master:  1ef381a0646c6e0bbe2ee8fb719bf057674b504b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
master revert due to nearly-perma orange Gu: c435661fb4de45e6e1a2e41db2c29d9e407a79d1

https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=7a0971e496aa
https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=8a6c8de66a9e

I did see some green so I am not sure what happened. Please investigate, thanks!
Status: RESOLVED → REOPENED
Flags: needinfo?(iliu)
Resolution: FIXED → ---
Sorry, false alarm. The offending bug should be bug 1043643 and is already backed out.

master: d5562731ae2c1eb05a887026301d1b20a16625eb
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Flags: needinfo?(iliu)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.