Closed Bug 1074086 Opened 10 years ago Closed 10 years ago

an embedded widget is invalid for a package app between installation and rebooting

Categories

(Firefox OS Graveyard :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S6 (10oct)

People

(Reporter: CuveeHsu, Assigned: CuveeHsu)

References

Details

Attachments

(3 files, 1 obsolete file)

346 bytes, application/x-web-app-manifest+json
Details
142 bytes, application/x-web-app-manifest+json
Details
1.73 KB, patch
CuveeHsu
: review+
Details | Diff | Splinter Review
An embedded widget is valid if the |src| is in the |widgetPages|. The rule should always work after the app is installed.
Blocks: 1062062
Hello fabrice,
I'm not sure how the marketplace generates the mini-manifest.
If there's |widgetPages| in the main-manifest, will the |widgetPages| be cloned to the mini-manifest?
Flags: needinfo?(fabrice)
(In reply to Junior Hsu [:juniorhsu] from comment #1)
> Hello fabrice,
> I'm not sure how the marketplace generates the mini-manifest.
> If there's |widgetPages| in the main-manifest, will the |widgetPages| be
> cloned to the mini-manifest?

No, there is no reason to add the widget pages to the mini manifest. How is this related to comment #0? Can you describes what the issue is?
Flags: needinfo?(fabrice)
The |widgetPages| is not in webapps.json file. Actually, the _saveWidgetsFullPage[1] is not called as installing a package app.

My origin guess is owing to mini-manifest but it's wrong.

I'm not sure where to save the widget information.
Maybe start tracking from updateAppHandlers[2]?

[1] http://dxr.mozilla.org/mozilla-central/source/dom/apps/Webapps.jsm#339
[2] http://dxr.mozilla.org/mozilla-central/source/dom/apps/Webapps.jsm#1817
Flags: needinfo?(fabrice)
Yep, we can add that to updateAppHandlers().
Flags: needinfo?(fabrice)
Assignee: nobody → juhsu
Attached file Main manifest
Hello Junior,
Attached is a main manifest to reproduce the bug. 'widgetPages' entry in webapps.json is an empty array just after installing a package app.
Attached file Mini manifest
Hello Junior,
Attached is a mini manifest to reproduce the bug. ("xxx.xxx.xxx.xxx" is the IP of test server.)
Attached patch saveWidgetAsUpdateAppHandlers (obsolete) — Splinter Review
Save widgetPages in UpdateAppHandlers and remove redundant saving
Attachment #8500310 - Flags: review?(fabrice)
Attachment #8500310 - Flags: review?(fabrice) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Sorry for missing metadata  (facepalm)
Add metadata; carry r+.
Attachment #8500310 - Attachment is obsolete: true
Attachment #8501460 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/31a22c63a824
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S6 (10oct)
You need to log in before you can comment on or make changes to this bug.