1074107 - Add wallpaper test themes to dev-apps.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Comment 1

[Olle Klang]

Attachment: GitHub pull-request

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 8496735 [details] [review]
GitHub pull-request

I'd like these themes to do a bit more than changing the wallpaper, to be useful as starting points for people that want to build other themes.

Comment 3

[[:fabrice] Fabrice Desré]

Francisco, I added some gaia-theme.css changes in https://github.com/fabricedesre/gaia/tree/test-themes but basically nothing works - even the wallpaper switching... Any idea why?

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 25334

This was a tricky one.

We have changes the gaia-theme element, so it doesn't contain /gaia-theme/style.css anymore, but gaia-theme/gaia-theme.css

That tiny thing was creating a build error.

I've updated the PR, it needed rebase and fixed the pointer to the correct css file in both apps.

Now, I hope, it should work.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Sorry, reviewing your specific branch (before I took previous PR as base), I can see that wallpapers images are 0 bytes, so that will explain why the wallpaper change doesn't work.

For the css changes, I changed:
--color-turquoise: #000;

So I can see black header in comms app like contacts and sms

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 25343

New PR based on Fabrice's branch.

Adding the correct images, also for testing the CSS changes I changed comms default color in the themes, theme 1 should be violet and theme 2 should be dark orange

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/2804b0a335bdb15ca4d51222112408bc3b7bf0a1


@Fabrice, do you want this in 2.1? Should I ask for approval ;) ?

Comment 8

[[:fabrice] Fabrice Desré]

Tony, do you want the test themes on 2.1 or are you fine with testing that on master only?

Comment 9

[Tony Chung [:tchung]]

(In reply to Fabrice Desré [:fabrice] from comment #8)
> Tony, do you want the test themes on 2.1 or are you fine with testing that
> on master only?

i'd like to test this on 2.1, since that is what's shipping.   can you uplift it there please?

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/734d3547fb6c65e8bc4dd1a52b26f70bdfee7474

Comment 11

[Tony Chung [:tchung]]

verified theme fixes on 2.1

Gaia-Rev        2866e1de1bcf07ae729fb1a8246fb89568bace6a
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/5315b9e6e3d9
Build-ID        20141112161201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141112.171455
FW-Date         Wed Nov 12 17:15:13 EST 2014
Bootloader      L1TC10011880