1074199 - Add clear_cache command to the production update script

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Mauro Doglio [:mdoglio]]

See bug 1074077 and bug 1072291

Comment 1

[Mauro Doglio [:mdoglio]]

Attachment: Github PR #231 on treeherder-service

Comment 2

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/703bf33297d6e75cf78c76f62580834a9a55cfac
Bug 1074199 - add clear_cache command to the update script

https://github.com/mozilla/treeherder-service/commit/f1bc715cfd81d659226bb7308ad2b9a8fbd304b1
Merge pull request #231 from mozilla/add-clear-cache-command

Bug 1074199 - add clear_cache command to the update script

Comment 3

[Ed Morley [:emorley]]

Is this is clearing out the cached top_revisions for each repo, right? (as well as anything else in the cache)

If so, I think this is dangerous to have in update.py, since if there are infra issues at the time of the deploy (eg like there were last night), then we fall back to json-pushes with no params, which only fetches the last 10 pushes. Which if there was a backlog in terms of pushlog ingestion, might mean we miss pushes older than #10.

Comment 4

[Ed Morley [:emorley]]

(In reply to Ed Morley [:edmorley] from comment #3)
> Is this is clearing out the cached top_revisions for each repo, right? (as
> well as anything else in the cache)
> 
> If so, I think this is dangerous to have in update.py, since if there are
> infra issues at the time of the deploy (eg like there were last night), then
> we fall back to json-pushes with no params, which only fetches the last 10
> pushes. Which if there was a backlog in terms of pushlog ingestion, might
> mean we miss pushes older than #10.

Bug 1076792 will reduce the risk slightly, but I'm wondering whether we should still make the cache clear manual-only?

Comment 5

[Ed Morley [:emorley]]

Broken this out to bug 1076797.