Closed
Bug 1074205
Opened 10 years ago
Closed 10 years ago
Enable devtools/netmonitor tests with e10s
Categories
(DevTools :: Netmonitor, defect)
DevTools
Netmonitor
Tracking
(e10s+)
RESOLVED
FIXED
Firefox 36
Tracking | Status | |
---|---|---|
e10s | + | --- |
People
(Reporter: harth, Assigned: vporof)
References
Details
Attachments
(1 file)
4.03 KB,
patch
|
ejpbruel
:
review+
|
Details | Diff | Splinter Review |
They're currently all disabled.
Updated•10 years ago
|
Blocks: dte10s
tracking-e10s:
--- → +
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8514272 -
Flags: review?(ejpbruel)
Assignee | ||
Comment 2•10 years ago
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8514272 [details] [diff] [review]
v1
Review of attachment 8514272 [details] [diff] [review]:
-----------------------------------------------------------------
I still don't understand why this works for tab.linkedBrowser.contentWindow.wrappedJSObject (it doesn't work for the debugger tests), but I can't see a reason to r- it as long as it turns the tests green on try. Perhaps it would be prudent to put a comment at that line saying that we're not sure why (and indeed if) this should work? Up to you.
Attachment #8514272 -
Flags: review?(ejpbruel) → review+
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Updated•10 years ago
|
Flags: qe-verify-
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•