1074246 - startup notification broken - default --enable-startup-notification

Status: RESOLVED DUPLICATE of bug 726479

(Core :: Widget: Gtk, defect, P3)

Description

[Cédric Bellegarde]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140925003805

Steps to reproduce:

https://bugzilla.gnome.org/show_bug.cgi?id=737576

Firefox doesn't handle startup notification when opening a link from an external request


Actual results:

startup notification continue until timeout


Expected results:

startup notification stop when firefox open newtab

Comment 1

[:Gijs (he/him)]

This really needs more detail, which the bug you linked to also doesn't provide.

What's a "startup notification"?

Which desktop environments is it relevant to? Just mutter?

How would I test this? How do I tell apart the "timeout" and the "Firefox told it to stop" cases?

Why is this a Firefox bug?

What API can we use to fix this? Is there documentation? Where?

Comment 2

[Cédric Bellegarde]

http://www.freedesktop.org/wiki/Software/startup-notification/

Here how i fix this bug in Lollypop music player:
https://github.com/gnumdk/lollypop/blob/master/src/application.py#L74

Comment 3

[Cédric Bellegarde]

So, if firefox is already started and open a new window, it needs to call:

gdk_notify_startup_complete ()

Comment 4

[:Gijs (he/him)]

(In reply to gnumdk from comment #3)
> So, if firefox is already started and open a new window, it needs to call:
> 
> gdk_notify_startup_complete ()

We never call that function even on normal startup ( http://mxr.mozilla.org/mozilla-central/search?string=notify_startup_complete ). How does that work, then? (CC'ing Karl who probably knows a lot more about this issue than I do)

Comment 5

[Cédric Bellegarde]

http://mxr.mozilla.org/mozilla-central/search?string=MOZ_ENABLE_STARTUP_NOTIFICATION&find=&findi=&filter=^%5B^\0%5D*%24&hitlimit=&tree=mozilla-central

Seems to be done without Gdk...

Comment 6

[Cédric Bellegarde]

// This will become obsolete when new GTK APIs are widely supported,
// as described here: http://bugzilla.gnome.org/show_bug.cgi?id=347375

Comment 7

[Karl Tomlinson (:karlt)]

Should be fixed by changes for bug 726479.