manage check_ami.py by puppet

RESOLVED FIXED

Status

Release Engineering
General Automation
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1973] )

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

3 years ago
Since we deployed runner on CentOS/Ubuntu we can get rid of the hack in
http://hg.mozilla.org/build/cloud-tools/file/da847f307007/cloudtools/aws/ami.py#l26
(Assignee)

Comment 1

3 years ago
Created attachment 8496960 [details] [diff] [review]
check_ami.diff

* Imported https://raw.githubusercontent.com/catlee/runner/master/example-tasks.d/0-check_ami.py
* need to install pyyaml
Attachment #8496960 - Flags: review?(catlee)

Updated

3 years ago
Attachment #8496960 - Flags: review?(catlee) → review+
(Assignee)

Comment 2

3 years ago
Comment on attachment 8496960 [details] [diff] [review]
check_ami.diff

remote:   https://hg.mozilla.org/build/puppet/rev/05106f2441d7
remote:   https://hg.mozilla.org/build/puppet/rev/6be7ab1ae1e2
Attachment #8496960 - Flags: checked-in+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/build/cloud-tools/rev/b8619bfb5da8
(Assignee)

Comment 4

3 years ago
Created attachment 8497187 [details] [diff] [review]
check_ami-1.diff

exit 1 on on-demand or in-house machines makes runner unhappy
Attachment #8497187 - Flags: review?
(Assignee)

Comment 5

3 years ago
Comment on attachment 8497187 [details] [diff] [review]
check_ami-1.diff

This shouldn't be installed on non-spot instances.
Attachment #8497187 - Flags: review?
(Assignee)

Comment 6

3 years ago
Comment on attachment 8497187 [details] [diff] [review]
check_ami-1.diff

Backed out:
remote:   https://hg.mozilla.org/build/puppet/rev/eb361af56027
remote:   https://hg.mozilla.org/build/puppet/rev/4cd7e2eaef3e

On-demand instances started failing because they don't have user-data.
Attachment #8497187 - Flags: checked-in-

Updated

3 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1973]
(Assignee)

Updated

2 years ago
Blocks: 1103123
(Assignee)

Comment 7

2 years ago
Created attachment 8528571 [details] [diff] [review]
chek_ami-puppet.diff

We can land this now, spot and on-demand instances are equal now!
Attachment #8496960 - Attachment is obsolete: true
Attachment #8497187 - Attachment is obsolete: true
Attachment #8528571 - Flags: review?(catlee)

Updated

2 years ago
Attachment #8528571 - Flags: review?(catlee) → review+
(Assignee)

Comment 8

2 years ago
Comment on attachment 8528571 [details] [diff] [review]
chek_ami-puppet.diff

remote:   https://hg.mozilla.org/build/puppet/rev/58d05207207c
remote:   https://hg.mozilla.org/build/puppet/rev/b9dab2793938
Attachment #8528571 - Flags: checked-in+
(Assignee)

Comment 9

2 years ago
https://hg.mozilla.org/build/cloud-tools/rev/aace5bbd0bcf
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.