107432 - Message|Label: can't unlabel a message

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[laurel]

Using oct29 commercial trunk build

Trying to undo a selected message's label assignment (assigning no label)
doesn't work. (Logged a bug 107423 about the checkmark display being incorrect
for the label menu on a selected message.) Regardless of whether there's a
checkmark appropriate to the current label assignment of the selected message,
selecting that same assignment to Undo/Set No Lable doesn't do anything.  The
assignment will stay.  Note: if changing to a different label assignment, the
label does indeed appear to change.

1.  Open Inbox or other mail folder, shown label column for thread pane.
2.  Select a message, Message|Label and select a label assignment, say "2" (no
current UI to change label text, current default is label 1-5).  Note the chosen
label does appear in the label column.
3.  Select the labeled message again (if not already selected), Message|Label
--> select  the same label again, "2".  Note nothing happens, message still has
same label assignment.

Result:  label assignment unchanged

Expected:  message reset to no label assignment, label is undone

Comment 1

[(not reading, please use [e-mail] instead)]

labels -> ssu

Comment 2

[Jesse Houwing]

There's one more thing to add to this:

The label in the menu is unselected, but the messagelist still shows the last
selected label.

Comment 3

[Sean Su]

this will be fixed by bug 81292

Comment 4

[laurel]

*** Bug 111184 has been marked as a duplicate of this bug. ***

Comment 5

[laurel]

Question (it's testplan writing time):  How will we handle "unlabeling" a
multiple message selection if the selected messages have varied labels already
applied?  Spec only covers single message selection type of situation.

Comment 6

[jglick]

Select multiple messages and then select "None" from the Label menu to remove 
labels for all messages.
http://www.mozilla.org/mailnews/specs/labels/images/Label4.gif

Comment 7

[laurel]

Sorry, I didn't focus (duh) on the None in the menu mock-up, I read the textual
part just above it.
So, are we going to have both ways of unlabeling -- by setting to the same label
(causing unchecked label menu item) and/or None?

Comment 8

[jglick]

Since its a group of mutually exclusive items (only one item can be selected per 
message at one time), its seems appropriate to me to select "None" to removed 
the label. Selecting the already checked label wouldn't do anything. 

Similar to Sort by. You can only sort by one method. Selecting the same sort 
method doesn't removed it. You have to pick another mutually exclusive sort 
option.

If this was a list of independent items, like the View Show/Hide menu items, 
selecting an already checked menu item would turn it off.

So, I guess Labels menu should use option buttons (circles) instead of check 
marks.

That seem appropriate?

Comment 9

[laurel]

Yes, I didn't like the checkmark idea too much.  The spec had me confused
because it talks about one thing and the image shows another.

Comment 10

[jglick]

Sorry about that. If everyone is ok with the behavior described in comment #8, I 
will correct the spec appropriately. Sean, you ok with this?

Comment 11

[Sean Su]

I had thought that the best way was to not have a checks or radio button next to
the Labels menu items.

If multiple messages were selected, and each message had a different label, how
is the menu to show this state?  This would probably require a 3 state type of
check or radio button, making it more complex than is really necessary.

Take a look at the way it is currently is on the trunk builds.  It has no checks
or radio buttons next to each label menu items.  Basically, selecting a specific
label will 'set' the label regardless if it's already set or not.

To clear label(s) from message(s), simply highlight the message(s) in question
and select the None label.

I think this is a cleaner way of implementing the labels in the menus (IMHO). 
If there's a better way of implementing this, let's file a new bug.  Tthis bug
talks about not being able to 'unlabel' a message, which is fixed.

Comment 12

[jglick]

Sean, yes, you are correct, we agreed not to display the checkboxes or radio 
buttons in front of the menu items. 

The Labels menu items should Behave like radio buttons though, not checkboxes. 
Meaning, the user picks "None" to remove a Label (radio button behavior), 
instead of selecting the current label to remove the label (checkbox behavior).

Comment 13

[laurel]

OK using commercial trunk build:
dec12, win98 and linux rh6.2
dec13, mac OS X

Comment 14

[Christopher Aillon (sabbatical, not receiving bugmail)]

*** Bug 117554 has been marked as a duplicate of this bug. ***