1074417 - [Search] Only English searches in Rocketbar show results for pre-installed apps no matter what language device is set to

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect, P1)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot

Description:
No matter what language phone is set to, searching for pre-installed apps in Rocketbar only show app if user searches for name of app in English. If user searches for app name as it appears on homescreen (when language is not set to English) the app does not appear. This result occurs regardless of what language the keyboard is set to.
   
Repro Steps:
1) Update a Flame device to BuildID: 20140929000203
2) Set phone language to French
3) Tap Rocketbar and search for "Clock"
4) Note that clock app titled "Horloge" appears in results
5) Clear search and type "Horloge"
  
Actual:
Searching for localized name of pre-installed app when phone is set to a given language does not produce said pre-installed app as result.
  
Expected: 
Searching for localized name of pre-installed app when phone is set to a given language produces pre-installed app as result.
  
Environmental Variables:
Device: Flame 2.1 KK (319mb)(Full Flash)
BuildID: 20140929000203
Gaia: 063de64a4ffc606e931ed7b09e93282713c46eca
Gecko: 055d46b81ed1
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
Repro frequency: 3/3, 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/12211/
See attached: screenshot & logcat

Comment 1

[Brogan Zumwalt [Inactive]]

Issue DOES occur on Flame 2.2 KK (319mb) & 2.0 KK (319mb)

Flame 2.2 KitKat Base (319mb)(Full Flash)
Device: Flame Master
Build ID: 20140929040202
Gaia: 2834baf4c7e34fe6ef335f0469f6d0f593c5922b
Gecko: 9d66436af432
Version: 35.0a1 (Master)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.0 KitKat Base (319mb)(Full Flash)
Device: Flame 2.0
Build ID: 20140929000203
Gaia: 5c2303ec4e367da060aa1b807d541a6549b3d72a
Gecko: 44f813760b88
Version: 32.0 (2.0)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Actual Results: Searching for localized name of pre-installed app when phone is set to a given language does not produce said pre-installed app as result.

Comment 2

[Delphine Lebédel [:delphine - Use needinfo]]

[Blocking Requested - why for this release]:
This is affecting all locales, amongst which important shipping locales

Comment 3

[Gregor Wagner [:gwagner]]

Not a regression so we can't block on it that late in the game. We will try to fix it asap.

Comment 4

[Kevin Grandon :kgrandon]

Going to work on this.

Comment 5

[Delphine Lebédel [:delphine - Use needinfo]]

Quick note: we can't start testing l10n until after string freeze. Since string freeze is always broken this means because of late feature landings, we can't test everything earlier in the game, unfortunately.
Thanks Kevin for taking this, very helpful!

Comment 6

[Kevin Grandon :kgrandon]

Attachment: Pull request

WIP - have a unit test, but also going to knock out an integration test if time permits.

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8497138 [details] [review]
Pull request

Dale - could you give this a review if you have time? Thanks!

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8497138 [details] [review]
Pull request

Or Ben - if you have some cycles I could use a review here. This is pretty bad and I'd like to get this uplifted if possible. Thanks!

Comment 9

[Dale Harvey (:daleharvey)]

Comment on attachment 8497138 [details] [review]
Pull request

Sorry for the delay, my device had a bunch of issues when I tried flashing new base image, finally got it working

This works great, I meant to file since my phone is now in italian and noticed this, cheers

Comment 10

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/c409ecfc94df89cacdbc9e587d226cccacf124d9

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8497138 [details] [review]
Pull request

I think that this is fairly important as this feature is essentially broken for non-english users which is the core audience of FirefoxOS. Please consider for uplift.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature implementation.
[User impact] if declined: Users who do not use the phone in english will not be able to search for apps. These users are are amongst our core audience.
[Testing completed]: Manual and unit testing.
[Risk to taking this patch] (and alternatives if risky): Only affects local app search which is already broken for non-english locales.
[String changes made]: None.

Comment 12

[bhavana bajaj [:bajaj]]

Comment on attachment 8497138 [details] [review]
Pull request

Approving as we do not want to ship with a broken search experience for non-english locales..

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/f4cbc36622f953158217cebe59c76e816652cb8e

Comment 14

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.1 & 2.2.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/10.

Flame v2.1 version:
Gaia-Rev        db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/211eae88f119
Build-ID        20141126001202
Version         34.0

Flame 2.2 version:
Gaia-Rev        824a61cccec4c69be9a86ad5cb629a1f61fa142f
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/acde07cb4e4d
Build-ID        20141125040209
Version         36.0a1