1074432 - [email] display of unsynced folder while offline shows both "No Mail in Folder" and "Load More Messages" overlapped

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Gregor Wagner [:gwagner]]

Attachment: mail

Current 2.1 build with empty folder on mozilla mail.
The 'Load more messages' seems off here.

Comment 1

[Gregor Wagner [:gwagner]]

[Blocking Requested - why for this release]:

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

I think this error case may be a function of a folder that has never been synced before, possibly involving atTop/atBottom being in a weird way.  Specifically I think our state ends up thinking "hey, this folder is empty!" at the same time as "hey, I can synchronize stuff into this folder!".

I think I'd replicated this in testing with a folder that was offline, albeit with some other stuff going on.

Comment 3

[James Burke [:jrburke]]

:asuth's suggestion of trying to sync a folder that has never been synced while offline reproduces the problem for me. Picking up this ticket, since I have a repro case I can actively debug at the moment.

Comment 4

[James Burke [:jrburke]]

Changing the title to be more targeted, but :gwagner, if you felt you hit this condition in a different fashion, feel free to add more info and we can retarget. Looking at the code, this seems like the most likely cause.

Comment 5

[James Burke [:jrburke]]

Attachment: GitHub pull request

Carrying discussion over from IRC: the main issue is that the slice's userCanGrowDownwards is true, but when offline, no messages have been synced, so hard to know for sure. userCanGrowDownwards as true makes sense (vs false) because it likely could grow if connected.

However, headerCount is 0 in the offline "show folder that has never been synced" case, so we can use this to know if "load more messages" makes sense to show. The user always has the option to use the refresh button in the toolbar to fetch messages, once online.

It is possible that longer term that we may want to encapsulate this state more concisely on a slice as something like "hasEverBeenSynced", and perhaps a custom message instead of "No Mail in Folder" with a "Folder not fetched yet" or something like that.

However, in the interests keeping this patch small if it is desired for 2.1, I went with the headerCount check, and not showing "Load More Messages" in the 0 case.

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8497201 [details] [review]
GitHub pull request

Your rationale makes sense, and it probably would be overkill to have the fancy sync flag.  Also, we definitely don't want to be calling requestGrowth right now in a zero-message folder anyways.  So this is probably all kinds of good on many levels.  Thanks for the super-fast fix!

Comment 7

[James Burke [:jrburke]]

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/aab923eb3bad5369c7b1b08d9aa0da99c2bc2b39

from pull request:
https://github.com/mozilla-b2g/gaia/pull/24534

Comment 8

[KTucker [:KTucker][Inactive 3/4/2016]]

QA, can we please verify that this is fixed on master and 2.1 once it is uplifted?

Comment 9

[James Burke [:jrburke]]

Comment on attachment 8497201 [details] [review]
GitHub pull request

[Approval Request Comment]

[Bug caused by] (feature/regressing bug #):
Bug 796474 - implementation of quasi-infinite scroll.

[User impact] if declined:
Email looks less polished, broken if trying to sync a folder for the first time while offline.

[Testing completed]:
Tested on flame device.

[Risk to taking this patch] (and alternatives if risky):
Very low risk. Just an extra conditional check that should have been there in the first place. It only comes into play/is activated in the offline, never-been-synced case.

[String changes made]:
none

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/94dcc25f2e34a4900ea58310c26be52bcb089161

Comment 11

[Edward Chen[:edchen]]

[Environment]
Gaia-Rev        778ebac47554e1c4b7e9a952d73e850f58123914
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/aa98eb8873a2
Build-ID        20141005160206
Version         34.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20140925.192608
FW-Date         Thu Sep 25 19:26:18 EDT 2014
Bootloader      L1TC10011800

[Result]
PASS

Comment 12

[Joshua Mitchell (Inactive)]

issue verified fixed - removing old keywords

Comment 13

[[:SalvadorR]]

This issue still reproduces on Flame 2.2 and 2.1. File a new bug 1105533

Results: "No Mail in Folder" text overlaps "Load More Messages"

Flame 2.1 

Device: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141126001202
Gaia: db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko: 211eae88f119
Version: 34.0 (2.1) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.2

Device: Flame 2.2  (319mb)(Kitkat Base)(Shallow Flash)
Build ID: 20141126040207
Gaia: 41b7be7c67167f367c3c4982ff08651d55455373
Gecko: 7bcc6573d204
Version: 36.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Comment 14

[KTucker [:KTucker][Inactive 3/4/2016]]

Removing verifyme because a new issue was written.