Support DiscardPadding with Vorbis in WebM demuxer

NEW
Unassigned

Status

()

Core
Audio/Video: Playback
3 years ago
2 years ago

People

(Reporter: kinetik, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
DiscardPadding support was added for Opus, but it can apply to Vorbis too.  See bug 1069660 comment 8.
Component: Audio/Video → Audio/Video: Playback
Do we need this in the WebMDemuxer?

if not I will close this as won't fix.
Flags: needinfo?(kinetik)
(Reporter)

Comment 2

2 years ago
Yes.
Flags: needinfo?(kinetik)
(Reporter)

Updated

2 years ago
Summary: Support DiscardPadding with Vorbis in WebMReader → Support DiscardPadding with Vorbis in WebM demuxer
How does it affect users?
(Reporter)

Comment 4

2 years ago
Ralph can probably explain this better than I can.
Flags: needinfo?(giles)
Basically, without this you can't cut from one encoded track to another without a gap in the audio in MSE. WebAudio resources will also need manual trimming.

This element is needed to support sample-accurate durations. Without it webm only represents vorbis audio up to the nearest frame boundary, and unless the edit is aligned there or a special crossfade cluster in encoded, there will be a gap or click at the transition. Our implementation will be lower quality and frustrate developers.

The Ogg container has always supported this, but the field (along with CodecDelay and SeekPreRoll) was added to Matroska for Opus in WebM.
Flags: needinfo?(giles)
You need to log in before you can comment on or make changes to this bug.