1074570 - Dismiss start pane on touch

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

I really like the tablet UI where you can see the address bar and the rest of the browser chrome and clicking outside the box brings you into the browser. The only way to escape the phone dialog is tap on one of the two buttons at the bottom or press the back button on the phone.

While this popup might drive more people to use Sync it makes getting to the browser much more difficult.

Comment 1

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

As we spoke on IRC, for the phone version, let's enable "click anywhere(above the navigation bar)" to go to Firefox Homepage.

Comment 3

[Chenxia Liu [:liuche]]

Attachment: Patch: dismiss on touch

Add a touch listener to the scrollview, so any touches that aren't handled by a child view will cause this activity to finish.

Comment 4

[Chenxia Liu [:liuche]]

Comment on attachment 8497702 [details] [diff] [review]
Patch: dismiss on touch

Clearing review flag, forgot to handle up/down scrolling!

Comment 5

[Chenxia Liu [:liuche]]

Attachment: Patch: dismiss on touch

This now handles click-to-dismiss, while preserving all other behavior.

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 8497909 [details] [diff] [review]
Patch: dismiss on touch

Review of attachment 8497909 [details] [diff] [review]:
-----------------------------------------------------------------

This, as far as I can tell, handles taps on phone or tablet. (Correct me if I'm wrong!)

That's fine by me, but if Yuan wants to argue that tablet should be tap-proof, be prepared to write a follow-up.

Comment 7

[Chenxia Liu [:liuche]]

Yuan, did you want the tap-to-dismiss to be for only phones (and not tablets)? Just want to clarify.

Comment 8

[Chenxia Liu [:liuche]]

Attachment: Patch: dismiss on touch - phone-only

Added the trivial check for isTablet or isTelevision. Carried over r+ and landed.

https://hg.mozilla.org/integration/fx-team/rev/611fa34ae086

Comment 9

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

(In reply to Chenxia Liu [:liuche] from comment #7)
> Yuan, did you want the tap-to-dismiss to be for only phones (and not
> tablets)? Just want to clarify.

Talked to Chenxia. It'd be nice if this only applies to phones.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/611fa34ae086

Comment 11

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed on
Build: Firefox for Android 35.0a1 (2014-10-02)
Device: Nexus 4 (Android 4.4.4)

Comment 12

[Brad Lassey [:blassey] (use needinfo?)]

[Tracking Requested - why for this release]:

Comment 13

[Lawrence Mandel [:lmandel] (use needinfo)]

This fix has been verified on m-c. Can you please submit an Aurora uplift request?

Comment 14

[Chenxia Liu [:liuche]]

Comment on attachment 8498303 [details] [diff] [review]
Patch: dismiss on touch - phone-only

Approval Request Comment
[Feature/regressing bug #]: bug 1042809 feature
[User impact if declined]: Users won't be able to dismiss start pane with touch on phones
[Describe test coverage new/current, TBPL]: verified on nightly
[Risks and why]: very low, add a dismiss handler in onboarding code
[String/UUID change made/needed]: none

Comment 15

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8498303 [details] [diff] [review]
Patch: dismiss on touch - phone-only

Aurora+

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f3d93c4d59e8

Comment 17

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed on
Build: Firefox for Android 34.0a2 (2014-10-08)
Device: Motorola Razr (Android 4.1.2)