Closed Bug 1074570 Opened 10 years ago Closed 10 years ago

Dismiss start pane on touch

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox32 unaffected, firefox33 unaffected, firefox34+ verified, firefox35 verified, fennec34+)

VERIFIED FIXED
Firefox 35
Tracking Status
firefox32 --- unaffected
firefox33 --- unaffected
firefox34 + verified
firefox35 --- verified
fennec 34+ ---

People

(Reporter: kbrosnan, Assigned: liuche)

References

Details

Attachments

(1 file, 2 obsolete files)

I really like the tablet UI where you can see the address bar and the rest of the browser chrome and clicking outside the box brings you into the browser. The only way to escape the phone dialog is tap on one of the two buttons at the bottom or press the back button on the phone.

While this popup might drive more people to use Sync it makes getting to the browser much more difficult.
As we spoke on IRC, for the phone version, let's enable "click anywhere(above the navigation bar)" to go to Firefox Homepage.
Summary: [first run] phone UI hiding the browser chrome makes Firefox look broken → Dismiss start pane on touch
Attached patch Patch: dismiss on touch (obsolete) — Splinter Review
Add a touch listener to the scrollview, so any touches that aren't handled by a child view will cause this activity to finish.
Assignee: nobody → liuche
Status: NEW → ASSIGNED
Attachment #8497702 - Flags: review?(rnewman)
Comment on attachment 8497702 [details] [diff] [review]
Patch: dismiss on touch

Clearing review flag, forgot to handle up/down scrolling!
Attachment #8497702 - Flags: review?(rnewman)
Attached patch Patch: dismiss on touch (obsolete) — Splinter Review
This now handles click-to-dismiss, while preserving all other behavior.
Attachment #8497702 - Attachment is obsolete: true
Attachment #8497909 - Flags: review?(rnewman)
Comment on attachment 8497909 [details] [diff] [review]
Patch: dismiss on touch

Review of attachment 8497909 [details] [diff] [review]:
-----------------------------------------------------------------

This, as far as I can tell, handles taps on phone or tablet. (Correct me if I'm wrong!)

That's fine by me, but if Yuan wants to argue that tablet should be tap-proof, be prepared to write a follow-up.
Attachment #8497909 - Flags: review?(rnewman) → review+
Yuan, did you want the tap-to-dismiss to be for only phones (and not tablets)? Just want to clarify.
Flags: needinfo?(ywang)
Added the trivial check for isTablet or isTelevision. Carried over r+ and landed.

https://hg.mozilla.org/integration/fx-team/rev/611fa34ae086
Attachment #8497909 - Attachment is obsolete: true
Attachment #8498303 - Flags: review+
Flags: needinfo?(ywang)
Target Milestone: --- → Firefox 35
(In reply to Chenxia Liu [:liuche] from comment #7)
> Yuan, did you want the tap-to-dismiss to be for only phones (and not
> tablets)? Just want to clarify.

Talked to Chenxia. It'd be nice if this only applies to phones.
https://hg.mozilla.org/mozilla-central/rev/611fa34ae086
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified as fixed on
Build: Firefox for Android 35.0a1 (2014-10-02)
Device: Nexus 4 (Android 4.4.4)
Status: RESOLVED → VERIFIED
[Tracking Requested - why for this release]:
tracking-fennec: ? → 34+
This fix has been verified on m-c. Can you please submit an Aurora uplift request?
Flags: needinfo?(liuche)
Comment on attachment 8498303 [details] [diff] [review]
Patch: dismiss on touch - phone-only

Approval Request Comment
[Feature/regressing bug #]: bug 1042809 feature
[User impact if declined]: Users won't be able to dismiss start pane with touch on phones
[Describe test coverage new/current, TBPL]: verified on nightly
[Risks and why]: very low, add a dismiss handler in onboarding code
[String/UUID change made/needed]: none
Attachment #8498303 - Flags: approval-mozilla-aurora?
Flags: needinfo?(liuche)
Comment on attachment 8498303 [details] [diff] [review]
Patch: dismiss on touch - phone-only

Aurora+
Attachment #8498303 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed on
Build: Firefox for Android 34.0a2 (2014-10-08)
Device: Motorola Razr (Android 4.1.2)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: