1074585 - TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/xpcshell/tests/mailnews/compose/test/unit/test_detectAttachmentCharset.js | "Shift_JIS" == "UTF-8" - See following stack:

Status: RESOLVED FIXED

(MailNews Core :: Internationalization, defect)

Description

[Joshua Cranmer [:jcranmer]]

Filing a new bug on this issue, but this is pursuant to the last comment I made.

Thoughts on the correct way to go about dealing with this?

Comment 1

[Ed Morley [:emorley]]

Typo in dep bug number?

Comment 2

[Henri Sivonen (:hsivonen)]

(In reply to Ed Morley [:edmorley] from comment #1)
> Typo in dep bug number?

Yes.

Comment 3

[Henri Sivonen (:hsivonen)]

(In reply to Joshua Cranmer [:jcranmer] from comment #0)
> Thoughts on the correct way to go about dealing with this?

If the contents of the file are valid UTF-8, label as UTF-8. Otherwise, attach as unlabeled.

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: bug1074585_test_detectAttachmentCharset.patch

Like this? At least the test passes.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

I can see that we will receive some bug reports saying 'Hey! Thunderbird does not set charset from version xx.'.

BUT attachment 8500143 [details] [diff] [review] might be better than setting wrong charset on the current trunk.

Comment 6

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8500143 [details] [diff] [review]
bug1074585_test_detectAttachmentCharset.patch

Review of attachment 8500143 [details] [diff] [review]:
-----------------------------------------------------------------

I'm honestly surprised the fix is this simple, as I thought lacking a charset would cause our compose code to do things with Content-Transfer-Encodings it shouldn't be doing. But after running some manual tests, those bad things that I thought would happen didn't.

The biggest "regression" is that this labels US-ASCII as UTF-8. Which might not be a bad thing, because it stops our code from trying to convert LF to CRLF line endings. On the downside, we also force all UTF-8 blobs to use Base64 encoding. I'm not going to ask you to change these, but we should keep a close eye on people filing regressions.

::: mailnews/base/util/nsMsgUtils.cpp
@@ +2387,5 @@
> +    NS_ENSURE_SUCCESS(rv, rv);
> +
> +    bool isMore = true;
> +    bool isUTF8Compat = true;
> +    while (isMore && isUTF8Compat && 

EWHITESPACE

Comment 7

[Legacy TBPL/Treeherder Robot]

clokep
https://tbpl.mozilla.org/php/getParsedLog.php?id=49592429&tree=Thunderbird-Trunk
TB Windows XP 32-bit comm-central debug test xpcshell on 2014-10-05 13:59:15
revision: ef1a562c5d12
slave: t-xp32-ix-080

TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\mailnews\compose\test\unit\test_detectAttachmentCharset.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/tests/xpcshell/tests/mailnews/compose/test/unit/test_detectAttachmentCharset.js | "UTF-8" == "windows-1252" - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\tests\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | None |  A promise chain failed to handle a rejection: 2147500036 - rejection date: Sun Oct 05 2014 13:21:55 GMT-0800 (Pacific Standard Time) - See following stack:
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\mailnews\compose\test\unit\test_messageHeaders.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/tests/xpcshell/tests/mailnews/compose/test/unit/test_messageHeaders.js | "text/plain; charset=windows-1252" == "text/plain; charset=UTF-8" - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\tests\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | None |  A promise chain failed to handle a rejection: 2147500036 - rejection date: Sun Oct 05 2014 13:21:56 GMT-0800 (Pacific Standard Time) - See following stack:
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\mailnews\import\test\unit\test_shiftjis_csv.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | resources/import_helper.js | "名無しの権兵衛" == "–¼–³‚µ‚ÌŒ •º‰q" - See following stack:
TEST-UNEXPECTED-FAIL | resources/import_helper.js | 2147500036 - See following stack:
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_autoFill_default_behavior.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Didn't find the current result ('moz-action:searchengine,{"engineName":"Bing","input":"visited/v","searchQuery":"visited/v"}', 'Bing') in matches - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\tests\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_visiturl.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Didn't find the current result ('moz-action:searchengine,{"engineName":"Bing","input":"mozilla/rum","searchQuery":"mozilla/rum"}', 'Bing') in matches - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\tests\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit_ipc\test_encoding.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/tests/xpcshell/tests/uriloader/exthandler/tests/unit_ipc/test_encoding.js | [31,139,8,0,22,90,138,72,2,3,43,73,45,46,225,2,0,198,53,185,59,5,0,0,0] deepEqual [116,101,115,116,10] - See following stack:
Return code: 1

Comment 8

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/fdfc4f1a8c6e -> FIXED