Closed Bug 1074681 Opened 5 years ago Closed 5 years ago

Hide old share this link and copy and email buttons

Categories

(Hello (Loop) :: Client, enhancement, P1)

enhancement
Points:
1

Tracking

(firefox35 fixed, firefox36 fixed)

RESOLVED FIXED
mozilla36
Iteration:
36.3
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
Blocking Flags:
backlog Fx35+

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [rooms])

User Story

When the rooms implementation is functional:

* Hide the "Share this link" UI when loop.rooms.enabled is true
* Ensure call url is not obtained when loop.rooms.enabled is true
* Ensure the ToS is displayed under the Rooms list (or somewhere!)

Note: Keep the preference available, in case rooms has to be backed out for some reason.

Attachments

(1 file)

No description provided.
User Story: (updated)
Severity: normal → enhancement
Whiteboard: [rooms] → [rooms] [blocked by working rooms]
backlog: --- → Fx35+
Priority: -- → P1
User Story: (updated)
Summary: Remove old share this link and copy and email buttons → Hide old share this link and copy and email buttons
User Story: (updated)
Assignee: nobody → standard8
Iteration: --- → 36.3
Points: --- → 1
Blocks: 1100258
This hides the old items. I've changed the background colour so that the ToS is consistent with the rest of the display, and the background is consistent with the mock-ups.
Attachment #8523730 - Flags: review?(nperriault)
For test/QA purposes:

- loop.rooms.enabled=false should show just the call url generation and contacts tabs
- loop.rooms.enabled=true should show just the rooms and contacts tabs
- With enabled=true, the user should still be able to receive call urls from before the preference was changed.
(In reply to Mark Banner (:standard8) from comment #2)
> - With enabled=true, the user should still be able to receive call urls from
> before the preference was changed.

"receive call urls" was meant to be "receive calls from previously generated call urls".
Attachment #8523730 - Flags: review?(nperriault) → review?(mdeboer)
Comment on attachment 8523730 [details] [diff] [review]
When Loop "rooms" are enabled, hide the old call url generation UI.

Review of attachment 8523730 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/loop/content/shared/css/panel.css
@@ +13,5 @@
>    overflow: hidden;
>  }
>  
> +.panel-rooms {
> +  background: #f5f5f5;

can you add a comment here to explain its purpose? I suspect it'll be revisited soon enough when OS theme support comes into play.

We really need to diverge from the spec to support high contrast themes on windows, for example. so if you can remove this style, I'd be very happy.
Attachment #8523730 - Flags: review?(mdeboer) → review+
(In reply to Mike de Boer [:mikedeboer] from comment #4)
> > +.panel-rooms {
> > +  background: #f5f5f5;
> 
> can you add a comment here to explain its purpose? I suspect it'll be
> revisited soon enough when OS theme support comes into play.
> 
> We really need to diverge from the spec to support high contrast themes on
> windows, for example. so if you can remove this style, I'd be very happy.

Ok, I've removed it - and from the rooms list itself. This then matches the existing panel better. I'll hopefully be showing this to UX soon, so I'm sure they will say if they don't like it.
https://hg.mozilla.org/integration/fx-team/rev/183a6ada079e
Whiteboard: [rooms] [blocked by working rooms] → [rooms]
Target Milestone: --- → mozilla36
https://hg.mozilla.org/mozilla-central/rev/183a6ada079e
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Flags: qe-verify-
Comment on attachment 8523730 [details] [diff] [review]
When Loop "rooms" are enabled, hide the old call url generation UI.

Approval Request Comment

requirement for Loop Rooms support for Aurora/35
On m-c; testing with rooms server changes now live in production

[String/UUID change made/needed]: none
Attachment #8523730 - Flags: approval-mozilla-aurora?
Attachment #8523730 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.